Skip to content

Conversation

@miguelCyclone
Copy link
Collaborator

@miguelCyclone miguelCyclone commented Nov 24, 2025

Description
This PR replaces the previous NewMultipleNodesClient() usage with a single-client configuration based on NewClient()

Changes:

  • Removed majority-rule logic from cli.go and service,go
  • Updated to initialise a NewClient() instance from the first QueryServiceURLs entry.

Reasoning:

  • Current integration uses a duplicated URL value for QueryServiceURLs.
  • The Asana ticket (“Remove majority rule”) requests deprecation of the multi-node client.
  • NewClient() matches the desired simplified behaviour while keeping compatibility with the EspressoClient interface.

Tests:

  • just smoke-tests → passed
  • just fast-tests→ passed
  • Code builds successfully inside Nix shell
  • No changes to CLI/API surface

Let me know if you want any adjustments or a different approach.


@CLAassistant
Copy link

CLAassistant commented Nov 24, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants