fix: decoding of JsonRpc messages

sharedRoutine · sharedRoutine · commit 6c69b4a91566 · 2025-10-30T10:46:27.000+01:00
diff --git a/.changeset/violet-nails-jump.md b/.changeset/violet-nails-jump.md
@@ -0,0 +1,5 @@
+---
+"@effect/rpc": patch
+---
+
+Fix decoding JsonRpc messages
diff --git a/packages/rpc/src/RpcSerialization.ts b/packages/rpc/src/RpcSerialization.ts
@@ -171,14 +171,15 @@ function decodeJsonRpcRaw(
     const messages: Array<RpcMessage.FromClientEncoded | RpcMessage.FromServerEncoded> = []
     for (let i = 0; i < decoded.length; i++) {
       const message = decodeJsonRpcMessage(decoded[i])
+      messages.push(message)
       if (message._tag === "Request") {
         batch.size++
         batches.set(message.id, batch)
       }
     }
     return messages
   }
-  return Array.isArray(decoded) ? decoded.map(decodeJsonRpcMessage) : [decodeJsonRpcMessage(decoded)]
+  return [decodeJsonRpcMessage(decoded)]
 }
 
 function decodeJsonRpcMessage(decoded: JsonRpcMessage): RpcMessage.FromClientEncoded | RpcMessage.FromServerEncoded {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@effect/rpc": patch
 +---
++
 +Fix decoding JsonRpc messages
Original file line number	Diff line number	Diff line change
`@@ -171,14 +171,15 @@ function decodeJsonRpcRaw(`
`171`	`171`	`const messages: Array<RpcMessage.FromClientEncoded \| RpcMessage.FromServerEncoded> = []`
`172`	`172`	`for (let i = 0; i < decoded.length; i++) {`
`173`	`173`	`const message = decodeJsonRpcMessage(decoded[i])`
	`174`	`+ messages.push(message)`
`174`	`175`	`if (message._tag === "Request") {`
`175`	`176`	`batch.size++`
`176`	`177`	`batches.set(message.id, batch)`
`177`	`178`	`}`
`178`	`179`	`}`
`179`	`180`	`return messages`
`180`	`181`	`}`
`181`		`- return Array.isArray(decoded) ? decoded.map(decodeJsonRpcMessage) : [decodeJsonRpcMessage(decoded)]`
	`182`	`+ return [decodeJsonRpcMessage(decoded)]`
`182`	`183`	`}`
`183`	`184`
`184`	`185`	`function decodeJsonRpcMessage(decoded: JsonRpcMessage): RpcMessage.FromClientEncoded \| RpcMessage.FromServerEncoded {`