Skip to content

Commit c733aea

Browse files
ditmanEdwinRomelta
authored andcommitted
[video_player_web] Add a custom analysis_options file to video_player_web. (flutter#2658)
flutter/plugins is currently red because inline analysis checks are no longer honored. `video_player_web` used a web-only API that was being flagged (correctly) by the analyzer, but suppressed inline via `// ignore` comments. Now that `// ignore` comments don't work, the tree has gone red. A proper fix for `video_player_web` will take longer than acceptable to unblock the flutter/plugins tree. This is a temporary mitigation so work can resume.
1 parent 773ed38 commit c733aea

4 files changed

Lines changed: 16 additions & 1 deletion

File tree

packages/video_player/video_player_web/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.1.2+2
2+
3+
* Add `analysis_options.yaml` to the package, so we can ignore `undefined_prefixed_name` errors. Works around https://github.com/flutter/flutter/issues/41563.
4+
15
## 0.1.2+1
26

37
* Make the pedantic dev_dependency explicit.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# This is a temporary file to allow us to unblock the flutter/plugins repo CI.
2+
# It disables some of lints that were disabled inline. Disabling lints inline
3+
# is no longer possible, so this file is required.
4+
# TODO(ditman) https://github.com/flutter/flutter/issues/55000 (clean this up)
5+
6+
include: ../../../analysis_options.yaml
7+
8+
analyzer:
9+
errors:
10+
undefined_prefixed_name: ignore

packages/video_player/video_player_web/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: video_player_web
22
description: Web platform implementation of video_player
33
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_web
4-
version: 0.1.2+1
4+
version: 0.1.2+2
55

66
flutter:
77
plugin:

script/incremental_build.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ source "$SCRIPT_DIR/common.sh"
1616
CUSTOM_ANALYSIS_PLUGINS=(
1717
"in_app_purchase"
1818
"camera"
19+
"video_player/video_player_web"
1920
)
2021
# Comma-separated string of the list above
2122
readonly CUSTOM_FLAG=$(IFS=, ; echo "${CUSTOM_ANALYSIS_PLUGINS[*]}")

0 commit comments

Comments
 (0)