Skip to content

Commit 3fa55a4

Browse files
authored
[unit test][pfcwd] Fix tests that require sudo access (sonic-net#1340)
* mock os.geteuid * rearrange imports
1 parent 7924bd1 commit 3fa55a4

1 file changed

Lines changed: 14 additions & 4 deletions

File tree

tests/pfcwd_test.py

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
import imp
22
import os
33
import sys
4+
from unittest.mock import patch
45

56
from click.testing import CliRunner
7+
68
from utilities_common.db import Db
79

810
from .pfcwd_input.pfcwd_test_vectors import *
@@ -78,7 +80,8 @@ def executor(self, testcase):
7880
if 'rc_output' in input:
7981
assert result.output == input['rc_output']
8082

81-
def test_pfcwd_start_ports_valid(self):
83+
@patch('pfcwd.main.os')
84+
def test_pfcwd_start_ports_valid(self, mock_os):
8285
# pfcwd start --action drop --restoration-time 200 Ethernet0 200
8386
import pfcwd.main as pfcwd
8487
runner = CliRunner()
@@ -92,6 +95,7 @@ def test_pfcwd_start_ports_valid(self):
9295
print(result.output)
9396
assert result.output == pfcwd_show_config_output
9497

98+
mock_os.geteuid.return_value = 0
9599
result = runner.invoke(
96100
pfcwd.cli.commands["start"],
97101
[
@@ -112,7 +116,8 @@ def test_pfcwd_start_ports_valid(self):
112116
assert result.exit_code == 0
113117
assert result.output == pfcwd_show_start_config_output_pass
114118

115-
def test_pfcwd_start_actions(self):
119+
@patch('pfcwd.main.os')
120+
def test_pfcwd_start_actions(self, mock_os):
116121
# pfcwd start --action fwd --restoration-time 200 Ethernet0 200
117122
import pfcwd.main as pfcwd
118123
runner = CliRunner()
@@ -126,6 +131,7 @@ def test_pfcwd_start_actions(self):
126131
print(result.output)
127132
assert result.output == pfcwd_show_config_output
128133

134+
mock_os.geteuid.return_value = 0
129135
result = runner.invoke(
130136
pfcwd.cli.commands["start"],
131137
[
@@ -267,7 +273,8 @@ def test_pfcwd_config_with_ports(self):
267273
assert result.exit_code == 0
268274
assert result.output == show_pfcwd_config_with_ports
269275

270-
def test_pfcwd_start_ports_masic_valid(self):
276+
@patch('pfcwd.main.os')
277+
def test_pfcwd_start_ports_masic_valid(self, mock_os):
271278
# pfcwd start --action forward --restoration-time 200 Ethernet0 200
272279
import pfcwd.main as pfcwd
273280
runner = CliRunner()
@@ -280,6 +287,7 @@ def test_pfcwd_start_ports_masic_valid(self):
280287
print(result.output)
281288
assert result.output == show_pfc_config_all
282289

290+
mock_os.geteuid.return_value = 0
283291
result = runner.invoke(
284292
pfcwd.cli.commands["start"],
285293
[
@@ -300,7 +308,8 @@ def test_pfcwd_start_ports_masic_valid(self):
300308
assert result.exit_code == 0
301309
assert result.output == show_pfc_config_start_pass
302310

303-
def test_pfcwd_start_actions_masic(self):
311+
@patch('pfcwd.main.os')
312+
def test_pfcwd_start_actions_masic(self, mock_os):
304313
# pfcwd start --action drop --restoration-time 200 Ethernet0 200
305314
import pfcwd.main as pfcwd
306315
runner = CliRunner()
@@ -313,6 +322,7 @@ def test_pfcwd_start_actions_masic(self):
313322
print(result.output)
314323
assert result.output == show_pfc_config_all
315324

325+
mock_os.geteuid.return_value = 0
316326
result = runner.invoke(
317327
pfcwd.cli.commands["start"],
318328
[

0 commit comments

Comments
 (0)