Skip to content

Pass by reference in freeVector#2762

Merged
jajhall merged 1 commit into
latestfrom
hipo-fix
Jan 21, 2026
Merged

Pass by reference in freeVector#2762
jajhall merged 1 commit into
latestfrom
hipo-fix

Conversation

@filikat
Copy link
Copy Markdown
Collaborator

@filikat filikat commented Jan 21, 2026

I accidentally passed a vector by value instead of reference in HiPO.
This is causing excessive memory usage and poor performance.
Closes #2760.

@filikat filikat requested a review from jajhall January 21, 2026 13:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.31%. Comparing base (574f304) to head (bdd75b3).
⚠️ Report is 194 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2762      +/-   ##
==========================================
- Coverage   81.32%   80.31%   -1.02%     
==========================================
  Files         349      348       -1     
  Lines       86132    86073      -59     
==========================================
- Hits        70051    69129     -922     
- Misses      16081    16944     +863     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jajhall jajhall merged commit f32c3cb into latest Jan 21, 2026
390 of 396 checks passed
@jajhall jajhall deleted the hipo-fix branch January 21, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants