fix: minor fixes for gui.default_key_tables and Pane#87
Merged
Conversation
Signed-off-by: Chris Grieser <[email protected]>
chrisgrieser
changed the title
search_mode to default_key_tablesdefault_key_tables and pane obj
DrKJeff16
reviewed
Dec 8, 2025
DrKJeff16
requested changes
Dec 8, 2025
Owner
DrKJeff16
left a comment
DrKJeff16
left a comment
There was a problem hiding this comment.
Could you sign your commits?
git rebase -i HEAD~2 --signoff
git push --force-with-lease
DrKJeff16
changed the title
default_key_tables and pane objgui.default_key_tables and Pane
DrKJeff16
added
documentation
DrKJeff16
approved these changes
Dec 8, 2025
Owner
DrKJeff16
left a comment
DrKJeff16
left a comment
There was a problem hiding this comment.
Never mind, don't worry. I'll sign them (I goofed up while trying to update your fork). Thanks for your contribution!
DrKJeff16
added a commit
that referenced
this pull request
Dec 8, 2025
Co-authored-by: Guennadi Maximov C <[email protected]> Signed-off-by: Guennadi Maximov C <[email protected]>
Contributor
Author
|
Was just about to read up on what signing commits is all about! Thanks |
DrKJeff16
added
merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
search_modetodefault_key_tablespane:get_current_working_dir()returns a url object, not a string. https://wezterm.org/config/lua/pane/get_current_working_dir.html