Skip to content

feat(config): add inactive_pane_hsb type#86

Merged
DrKJeff16 merged 2 commits into
DrKJeff16:mainfrom
AtifChy:feat/config/inactive_pane_hsb
Oct 21, 2025
Merged

feat(config): add inactive_pane_hsb type#86
DrKJeff16 merged 2 commits into
DrKJeff16:mainfrom
AtifChy:feat/config/inactive_pane_hsb

Conversation

@AtifChy
Copy link
Copy Markdown
Contributor

@AtifChy AtifChy commented Oct 20, 2025

Added missing inactive_pane_hsb field to Config class.

@AtifChy AtifChy requested a review from DrKJeff16 as a code owner October 20, 2025 17:43
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @AtifChy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Config class by adding a new field, inactive_pane_hsb. This addition provides users with the ability to customize the visual appearance of inactive panes through Hue, Saturation, and Brightness transformations, offering more granular control over the terminal's aesthetic.

Highlights

  • New Configuration Field: Introduced inactive_pane_hsb to the Config class, allowing users to specify Hue, Saturation, and Brightness transformations for inactive panes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the inactive_pane_hsb field to the Config class documentation. The new field is placed in the correct alphabetical order and is well-documented. I have one suggestion to improve the surrounding documentation, which appears to be misaligned. Addressing this would enhance the overall clarity and maintainability of the code.

Comment thread lua/wezterm/types/config.lua Outdated
Comment thread lua/wezterm/types/config.lua
@AtifChy AtifChy force-pushed the feat/config/inactive_pane_hsb branch from 1262fc5 to 6787941 Compare October 21, 2025 10:32
@AtifChy
Copy link
Copy Markdown
Contributor Author

AtifChy commented Oct 21, 2025

@DrKJeff16 done

Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Copy link
Copy Markdown
Owner

@DrKJeff16 DrKJeff16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected it now. Thanks for your contribution!

@DrKJeff16 DrKJeff16 merged commit 8be0939 into DrKJeff16:main Oct 21, 2025
1 check passed
@DrKJeff16 DrKJeff16 self-assigned this Feb 14, 2026
@DrKJeff16 DrKJeff16 added documentation Improvements or additions to documentation enhancement New feature or request missing-types Missing data types found new-types A PR addresses new data types and/or fields merged This PR has been merged successfully! labels Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request merged This PR has been merged successfully! missing-types Missing data types found new-types A PR addresses new data types and/or fields

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants