Skip to content

fix(docs): Reworked wezterm.on, many more corrections aswell.#65

Merged
DrKJeff16 merged 3 commits into
mainfrom
patch/documentation
Aug 16, 2025
Merged

fix(docs): Reworked wezterm.on, many more corrections aswell.#65
DrKJeff16 merged 3 commits into
mainfrom
patch/documentation

Conversation

@DrKJeff16
Copy link
Copy Markdown
Owner

@DrKJeff16 DrKJeff16 commented Aug 15, 2025 •
edited
Loading

Changes

  • Re-documented wezterm.on() using more definition-file-like structure
  • Fixed many descriptions in other adjacent files
  • Got rid of a bunch of useless aliases
  • Started using definition files structure

@craigmac I think you will agree with the decisions made

UPDATE

  • Moved types/init.lua to types/wezterm.lua
  • Removed types/wezterm/init.lua and merged it with wezterm.lua
  • Removed a bunch of useless aliases

@DrKJeff16 DrKJeff16 requested a review from craigmac August 15, 2025 17:56
@DrKJeff16 DrKJeff16 added documentation Improvements or additions to documentation enhancement New feature or request new-types A PR addresses new data types and/or fields needs-review A PR labeled with this is in need of review labels Aug 15, 2025
@DrKJeff16 DrKJeff16 force-pushed the patch/documentation branch 2 times, most recently from de136fa to 6b5d4d0 Compare August 15, 2025 23:51
@DrKJeff16
Copy link
Copy Markdown
Owner Author

DrKJeff16 commented Aug 15, 2025

FOR FUCKS SAKE GITHUB, WHY DO YOU UNSIGN MY COMMITS AFTER REBASE?????!!!!!

@DrKJeff16
fix!: Reworked wezterm.on, many more corrections aswell.
8ed40ff 
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16
fix!: Moved init.lua to wezterm.lua, got rid of some aliases.
1b73590 
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16
refactor!: Moved window event descriptions for each wezterm.on def.
c551815 
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16 DrKJeff16 force-pushed the patch/documentation branch from 6b5d4d0 to c551815 Compare August 15, 2025 23:56
craigmac
craigmac approved these changes Aug 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@craigmac craigmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

Comment thread lua/wezterm/types/config.lua
Comment thread lua/wezterm/types/events/window.lua
@DrKJeff16 DrKJeff16 merged commit 5ef2f41 into main Aug 16, 2025
2 checks passed
@DrKJeff16 DrKJeff16 deleted the patch/documentation branch August 16, 2025 00:00
@DrKJeff16 DrKJeff16 removed the needs-review A PR labeled with this is in need of review label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@craigmac craigmac craigmac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@craigmac craigmac

@DrKJeff16 DrKJeff16

Labels

documentation Improvements or additions to documentation enhancement New feature or request new-types A PR addresses new data types and/or fields

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DrKJeff16 @craigmac