.luarc.json cleanup#35
Merged
Merged
Conversation
DrKJeff16
reviewed
Aug 3, 2025
| "setType": true | ||
| }, | ||
| "completion": { | ||
| "autoRequire": true, |
Owner
There was a problem hiding this comment.
@craigmac Do we REALLY need "completion.autoRequire": true? If so, how come?
I always disable it in my LSP settings so I'm clueless.
Bear in mind I use Neovim as a text editor, (my config, for reference)
Contributor
Author
There was a problem hiding this comment.
True, we do not for this repo I'll remove it. I use neovim as well (typing this using Firenvim actually).
Closed
Also cleaned the formatting up and added schema for validation.
craigmac
force-pushed
the
fix-luarc-cleanup
branch
from
2de992d to
1870fe5
Compare
DrKJeff16
approved these changes
Aug 3, 2025
Owner
DrKJeff16
left a comment
DrKJeff16
left a comment
There was a problem hiding this comment.
All looks good. Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes