Skip to content

fix(init): Solving issue #9 .#11

Merged
justinsgithub merged 3 commits into
mainfrom
patch/documentation
Jul 25, 2025
Merged

fix(init): Solving issue #9 .#11
justinsgithub merged 3 commits into
mainfrom
patch/documentation

Conversation

@DrKJeff16
Copy link
Copy Markdown
Owner

Credits: #9

Copy link
Copy Markdown

@S1M0N38 S1M0N38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add all the combination?

Copy link
Copy Markdown
Owner Author

@DrKJeff16 DrKJeff16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add all the combination?

@S1M0N38 I think I've got it, though the number of combinations gets... huge to say the least. Should I push it?

Pretty much every combination, order be damned

Combinations

@DrKJeff16 DrKJeff16 requested a review from S1M0N38 July 24, 2025 21:21
@S1M0N38
Copy link
Copy Markdown

S1M0N38 commented Jul 24, 2025

Mine was just a question. Are we sure that this is the way to go? I mean, if wez add another flag for macOS, the literals will double again.

@DrKJeff16
Copy link
Copy Markdown
Owner Author

Mine was just a question. Are we sure that this is the way to go? I mean, if wez add another flag for macOS, the literals will double again.

@S1M0N38

If @justinsgithub agrees with the following (ordered) code snippet:

---@alias WindowDecorations
---|"NONE"
---|"TITLE"
---|"RESIZE"
---|"INTEGRATED_BUTTONS"
---|"MACOS_FORCE_DISABLE_SHADOW"
---|"MACOS_FORCE_ENABLE_SHADOW"
---|"MACOS_FORCE_SQUARE_CORNERS"
---|"MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"TITLE | RESIZE"
---|"TITLE | INTEGRATED_BUTTONS"
---|"TITLE | MACOS_FORCE_DISABLE_SHADOW"
---|"TITLE | MACOS_FORCE_ENABLE_SHADOW"
---|"TITLE | MACOS_FORCE_SQUARE_CORNERS"
---|"TITLE | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"RESIZE | INTEGRATED_BUTTONS"
---|"RESIZE | MACOS_FORCE_DISABLE_SHADOW"
---|"RESIZE | MACOS_FORCE_ENABLE_SHADOW"
---|"RESIZE | MACOS_FORCE_SQUARE_CORNERS"
---|"RESIZE | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"INTEGRATED_BUTTONS | MACOS_FORCE_DISABLE_SHADOW"
---|"INTEGRATED_BUTTONS | MACOS_FORCE_ENABLE_SHADOW"
---|"INTEGRATED_BUTTONS | MACOS_FORCE_SQUARE_CORNERS"
---|"INTEGRATED_BUTTONS | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"TITLE | RESIZE | INTEGRATED_BUTTONS"
---|"TITLE | RESIZE | MACOS_FORCE_DISABLE_SHADOW"
---|"TITLE | RESIZE | MACOS_FORCE_ENABLE_SHADOW"
---|"TITLE | RESIZE | MACOS_FORCE_SQUARE_CORNERS"
---|"TITLE | RESIZE | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"TITLE | INTEGRATED_BUTTONS | MACOS_FORCE_DISABLE_SHADOW"
---|"TITLE | INTEGRATED_BUTTONS | MACOS_FORCE_ENABLE_SHADOW"
---|"TITLE | INTEGRATED_BUTTONS | MACOS_FORCE_SQUARE_CORNERS"
---|"TITLE | INTEGRATED_BUTTONS | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_DISABLE_SHADOW"
---|"RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_ENABLE_SHADOW"
---|"RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_SQUARE_CORNERS"
---|"RESIZE | INTEGRATED_BUTTONS | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"TITLE | RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_DISABLE_SHADOW"
---|"TITLE | RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_ENABLE_SHADOW"
---|"TITLE | RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_SQUARE_CORNERS"
---|"TITLE | RESIZE | INTEGRATED_BUTTONS | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|string
-- Add other valid combinations if needed

Copy link
Copy Markdown
Owner Author

@DrKJeff16 DrKJeff16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated with descriptions and all valid combinations (that the docs seem to point to).

@justinsgithub @S1M0N38 Ready to merge.

@justinsgithub justinsgithub merged commit dfb15f0 into DrKJeff16:main Jul 25, 2025
1 check passed
@DrKJeff16 DrKJeff16 deleted the patch/documentation branch July 25, 2025 17:54
@DrKJeff16 DrKJeff16 mentioned this pull request Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants