fix(init): Solving issue #9 .#11
Merged
Merged
Conversation
Credits: #9 Signed-off-by: Guennadi Maximov C <[email protected]>
|
Mine was just a question. Are we sure that this is the way to go? I mean, if wez add another flag for macOS, the literals will double again. |
Owner
Author
If @justinsgithub agrees with the following (ordered) code snippet: ---@alias WindowDecorations
---|"NONE"
---|"TITLE"
---|"RESIZE"
---|"INTEGRATED_BUTTONS"
---|"MACOS_FORCE_DISABLE_SHADOW"
---|"MACOS_FORCE_ENABLE_SHADOW"
---|"MACOS_FORCE_SQUARE_CORNERS"
---|"MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"TITLE | RESIZE"
---|"TITLE | INTEGRATED_BUTTONS"
---|"TITLE | MACOS_FORCE_DISABLE_SHADOW"
---|"TITLE | MACOS_FORCE_ENABLE_SHADOW"
---|"TITLE | MACOS_FORCE_SQUARE_CORNERS"
---|"TITLE | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"RESIZE | INTEGRATED_BUTTONS"
---|"RESIZE | MACOS_FORCE_DISABLE_SHADOW"
---|"RESIZE | MACOS_FORCE_ENABLE_SHADOW"
---|"RESIZE | MACOS_FORCE_SQUARE_CORNERS"
---|"RESIZE | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"INTEGRATED_BUTTONS | MACOS_FORCE_DISABLE_SHADOW"
---|"INTEGRATED_BUTTONS | MACOS_FORCE_ENABLE_SHADOW"
---|"INTEGRATED_BUTTONS | MACOS_FORCE_SQUARE_CORNERS"
---|"INTEGRATED_BUTTONS | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"TITLE | RESIZE | INTEGRATED_BUTTONS"
---|"TITLE | RESIZE | MACOS_FORCE_DISABLE_SHADOW"
---|"TITLE | RESIZE | MACOS_FORCE_ENABLE_SHADOW"
---|"TITLE | RESIZE | MACOS_FORCE_SQUARE_CORNERS"
---|"TITLE | RESIZE | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"TITLE | INTEGRATED_BUTTONS | MACOS_FORCE_DISABLE_SHADOW"
---|"TITLE | INTEGRATED_BUTTONS | MACOS_FORCE_ENABLE_SHADOW"
---|"TITLE | INTEGRATED_BUTTONS | MACOS_FORCE_SQUARE_CORNERS"
---|"TITLE | INTEGRATED_BUTTONS | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_DISABLE_SHADOW"
---|"RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_ENABLE_SHADOW"
---|"RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_SQUARE_CORNERS"
---|"RESIZE | INTEGRATED_BUTTONS | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|"TITLE | RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_DISABLE_SHADOW"
---|"TITLE | RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_ENABLE_SHADOW"
---|"TITLE | RESIZE | INTEGRATED_BUTTONS | MACOS_FORCE_SQUARE_CORNERS"
---|"TITLE | RESIZE | INTEGRATED_BUTTONS | MACOS_USE_BACKGROUND_COLOR_AS_TITLEBAR_COLOR"
---|string
-- Add other valid combinations if needed |
Signed-off-by: Guennadi Maximov C <[email protected]>
DrKJeff16
commented
Jul 25, 2025
Owner
Author
DrKJeff16
left a comment
There was a problem hiding this comment.
I've updated with descriptions and all valid combinations (that the docs seem to point to).
@justinsgithub @S1M0N38 Ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Credits: #9