Skip to content

ci: Update GitHub Actions workflows based on Zizmor security reports #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DhavalGojiya merged 1 commit into from
Dec 5, 2025
Merged

ci: Update GitHub Actions workflows based on Zizmor security reports #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,14 @@ on:
- "v[0-9]" # Major version release (e.g., v1, v2, ..., v9)

jobs:
# -----------------------------
# Job 1: Solr Release Test
# -----------------------------
solr-release-test:
name: solr-release-test (Solr ${{ matrix.solr-version }})
runs-on: ubuntu-latest
permissions:
contents: read
Comment on lines +15 to +16
Copy link
Contributor

@cclauss cclauss Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be why pre-commit-ci/lite-action cannot write a commit.

Copy link
Owner Author

@DhavalGojiya DhavalGojiya Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the pre-commit lite action is defined inside .github/workflows/ci-test.yml,
and the job where it's defined already has all the required permissions.

I think I haven't configured the pre-commit lite CI bot in this repo.
That's probably the reason. Anyway, I'm going to remove this job.

Copy link
Contributor

@cclauss cclauss Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...

Make the whitespace change to a non-GitHub Actions file. I think that GitHub Actions cannot write to a GHA file.

trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/ci-test.yml

biome check..............................................................Passed

Copy link
Owner Author

@DhavalGojiya DhavalGojiya Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working with the action.yml whitespace issue either.

Copy link
Owner Author

@DhavalGojiya DhavalGojiya Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a final test. I just added the pre-commit CI lite bot to this repo.

Copy link
Owner Author

@DhavalGojiya DhavalGojiya Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boom.
Working after pre-commit CI lite bot added to this repo.

strategy:
matrix:
include:
Expand All @@ -24,6 +29,8 @@ jobs:
# -----------------------------
- name: 📥 Checkout Repository
uses: actions/checkout@v6
with:
persist-credentials: false

# -----------------------------
# 2. Setup Apache Solr (Release Action)
Expand Down
34 changes: 27 additions & 7 deletions .github/workflows/ci-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,43 @@ on:
branches: [ "main" ]

jobs:
# -----------------
# -----------------------------
# Job 1: Pre-commit
# -----------------
# -----------------------------
pre-commit:
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v6
- uses: pre-commit/[email protected]
- uses: pre-commit-ci/[email protected]
if: always()
# -----------------------------
# 1. Checkout Repository
# -----------------------------
- name: 📥 Checkout Repository
uses: actions/checkout@v6
with:
persist-credentials: false

# -----------------------------
# 2. Run Pre-commit hooks
# -----------------------------
- name: 🧹 Run Pre-commit hooks
uses: pre-commit/[email protected]

# -----------------------------
# Job 2: Package Checks & Build
# -----------------------------
package:
runs-on: ubuntu-latest
permissions:
contents: read
steps:
# -----------------------------
# 1. Checkout Repository
# -----------------------------
- name: 📥 Checkout Repository
uses: actions/checkout@v6
with:
persist-credentials: false

# -----------------------------
# 2. Setup Node.js
Expand Down Expand Up @@ -62,11 +78,13 @@ jobs:
run: npm run build

# -----------------------------
# Job 2: Test Custom Solr Action
# Job 3: Test Custom Solr Action
# -----------------------------
solr-dev-test:
name: solr-dev-test (Solr ${{ matrix.solr-version }})
runs-on: ubuntu-latest
permissions:
contents: read
strategy:
matrix:
include:
Expand All @@ -82,6 +100,8 @@ jobs:
# -----------------------------
- name: 📥 Checkout Repository
uses: actions/checkout@v6
with:
persist-credentials: false

# -----------------------------
# 2. Setup Apache Solr (Local Action)
Expand Down