Skip to content

Commit ef6bc53

Browse files
committed
try to get rid of GenerateBuiltinFilesCpp
it generates a cpp file, so no src file will include it. hence clang tidy *should* not need it, right?
1 parent 27c4995 commit ef6bc53

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/CMakeLists.txt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -410,10 +410,6 @@ add_custom_command(
410410
"${CMAKE_SOURCE_DIR}/cmake/Modules/GenerateBuiltinFilesList.cmake"
411411
WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}")
412412

413-
# Target to generate just builtin_files.cpp (used by util/ci/clang-tidy.sh)
414-
add_custom_target(GenerateBuiltinFilesCpp
415-
DEPENDS "${PROJECT_BINARY_DIR}/builtin_files.cpp")
416-
417413

418414
add_subdirectory(threading)
419415
add_subdirectory(content)
@@ -631,7 +627,7 @@ endif()
631627
add_library(EngineCommon OBJECT
632628
${independent_SRCS}
633629
)
634-
add_dependencies(EngineCommon GenerateVersion GenerateBuiltinFilesCpp)
630+
add_dependencies(EngineCommon GenerateVersion)
635631
target_link_libraries(EngineCommon
636632
sha256
637633
)

util/ci/clang-tidy.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ cmake -B build -DCMAKE_BUILD_TYPE=Debug \
55
-DRUN_IN_PLACE=TRUE \
66
-DENABLE_GETTEXT=FALSE \
77
-DBUILD_SERVER=TRUE
8-
cmake --build build --target GenerateVersion GenerateBuiltinFilesCpp
8+
cmake --build build --target GenerateVersion
99

1010
./util/ci/run-clang-tidy.py \
1111
-clang-tidy-binary=$CLANG_TIDY -p build \

0 commit comments

Comments
 (0)