ZKWAS-289 #81
Merged
ZKWAS-289 #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yymone
reviewed
Jul 1, 2024
| } | ||
|
|
||
| // Additional params afterwards | ||
| if (params.initial_context) { |
Collaborator
There was a problem hiding this comment.
This change will not affect our verification , correct?
Any issue if we do not put it at last? (I agree as it is optional so it should be put at last), just want to understand the affect
Collaborator
There was a problem hiding this comment.
This is a essential fix as currently we put context after auto_submit_network_ids in UI so we should keep this rule
yymone
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.