Skip to content

ZKWAS-228: add metadata param into interface for 'Creator Paid Proof' feature #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 4, 2024
Merged

ZKWAS-228: add metadata param into interface for 'Creator Paid Proof' feature #60

merged 8 commits into from
Apr 4, 2024

Conversation

@qozymandias
Copy link
Contributor

@qozymandias qozymandias commented Mar 26, 2024

@qozymandias qozymandias marked this pull request as ready for review March 27, 2024 03:25
@yymone
Copy link
Collaborator

yymone commented Mar 27, 2024

Please run npm run build and commit all mjs and cjs files.
This is because we didn't add this repo to npm so any service which include this lib need use git directly.
This means it will not have "npm run prepare" automatically, so we need upload the compiled js files.

yymone
yymone reviewed Mar 27, 2024
View reviewed changes
@qozymandias qozymandias force-pushed the ZKWAS-228-add-creator-pay-option branch from c5959ce to 7ca8bec Compare March 28, 2024 05:27
@qozymandias qozymandias changed the title ZKWAS-228: update interface with creator_paid_proof ZKWAS-228: add metadata into interface for 'Creator Paid Proof' param Apr 4, 2024
@qozymandias qozymandias changed the title ZKWAS-228: add metadata into interface for 'Creator Paid Proof' param ZKWAS-228: add metadata param into interface for 'Creator Paid Proof' feature Apr 4, 2024
@qozymandias qozymandias merged commit 4340cf5 into main Apr 4, 2024
yymone pushed a commit that referenced this pull request Apr 5, 2024
@qozymandias @yymone
ZKWAS-228: add metadata param into interface for 'Creator Paid Proof'…
e0c4228 
… feature (#60)
@qozymandias qozymandias deleted the ZKWAS-228-add-creator-pay-option branch April 16, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yymone yymone yymone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qozymandias @yymone