Skip to content

Conversation

@Maffooch
Copy link
Contributor

The original introduction of this action did not pin to a specific commit hash or version intentionally. This PR restores that decision

@dryrunsecurity
Copy link

DryRun Security

This pull request uses a GitHub Action (DefectDojo-Inc/notify-pr-reviewers-action) without pinning it to a specific commit SHA or version tag, which allows version floating and increases supply-chain risk if the action is compromised. Pin the action to a specific commit or tagged release to prevent accidental execution of malicious updates.

Insecure Dependency Management in GitHub Actions in .github/workflows/slack-pr-reminder.yml
Vulnerability Insecure Dependency Management in GitHub Actions
Description The GitHub Actions workflow uses 'DefectDojo-Inc/notify-pr-reviewers-action' without pinning it to a specific version (e.g., a commit SHA or a version tag like @v1). This practice, known as version floating, exposes the CI/CD pipeline to supply chain attacks. If the action's repository is compromised or a malicious update is pushed, this workflow will automatically execute the potentially harmful code, which could lead to secret exfiltration or other compromises.

uses: DefectDojo-Inc/notify-pr-reviewers-action # Do not use a specific version to always get the latest updates
with:
owner: "DefectDojo"
repository: "django-DefectDojo"


All finding details can be found in the DryRun Security Dashboard.

@Maffooch Maffooch closed this Oct 29, 2025
@Maffooch Maffooch reopened this Oct 29, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

This will fix a PR reviewer tool we wrote so thanks for catching this whoops @Maffooch

@Maffooch
Copy link
Contributor Author

Merging as this is a dep update with 2 approvals

@Maffooch Maffooch merged commit 059e304 into master Oct 30, 2025
173 of 183 checks passed
@Maffooch Maffooch deleted the notify-pr-pin-removal branch October 30, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants