Skip to content

Added Ability to Edit found_by value in API #13542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

Added Ability to Edit found_by value in API #13542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e9190a
Added code, tested on the api, not tested in pro-ui yet
Jino-T Oct 27, 2025
ce7b737
Update dojo/api_v2/serializers.py
Jino-T Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions dojo/api_v2/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1692,6 +1692,9 @@ class FindingSerializer(serializers.ModelSerializer):
many=True, read_only=True, source="risk_acceptance_set",
)
push_to_jira = serializers.BooleanField(default=False)
found_by = serializers.PrimaryKeyRelatedField(
queryset=Test_Type.objects.all(), many=True,
)
age = serializers.IntegerField(read_only=True)
sla_days_remaining = serializers.IntegerField(read_only=True, allow_null=True)
finding_meta = FindingMetaSerializer(read_only=True, many=True)
Expand Down Expand Up @@ -1774,6 +1777,16 @@ def update(self, instance, validated_data):
if parsed_vulnerability_ids:
save_vulnerability_ids(instance, parsed_vulnerability_ids)

# Get found_by from validated_data
found_by = validated_data.pop("found_by", None)
# Handle updates to found_by data
if found_by:
instance.found_by.set(found_by)
# If there is no argument entered for found_by, the user would like to clear out the values on the Finding's found_by field
# Findings still maintain original found_by value associated with their test
# In the event the user does not supply the found_by field at all, we do not modify it
elif isinstance(found_by, list) and len(found_by) == 0:
instance.found_by.clear()
instance = super().update(
instance, validated_data,
)
Expand Down