-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added Ability to Edit found_by value in API #13542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔴 Risk threshold exceeded.This pull request modifies a sensitive file (dojo/api_v2/serializers.py) with detected sensitive edits; review is recommended and you can configure sensitive paths and allowed authors in .dryrunsecurity.yaml. The scanner flagged the same file twice at a failing risk threshold but the findings are non-blocking.
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/api_v2/serializers.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
|
I wonder how this field is used/edited? In the code it looks like it's only used to maintain a list of test types that reported this finding via the set of duplicates? |
Use found_by.set to better replace values Co-authored-by: Cody Maffucci <[email protected]>
|
Good idea Cody. I tested your suggestion and it works in the API. |
mtesauro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
|
Not sure if three approvals is quite enough... |
[sc-11934]
Tested and functional in API & Pro UI
Not able to remove found_by value associated with finding's test.