Commit e9f42d8
authored
chore(ci): add final_status property on junit XML [APMSP-2610] (#178)
### What does this PR do?
Add a `<property name="dd_tags[test.final_status]" value="pass" />` on
every test case reported through junit
Also updated system-tests SHA, the used one was very old, and the
support for `final_status` in system-tests has been introduced recently
### Motivation
Some repositories intentionally use mechanisms that ignore test failures
(there are valid reasons to still execute those tests behind the
scenes).
In these cases, the reported test status cannot be relied upon by Test
Optimization to monitor repository health or trigger team notifications.
To ensure a consistent and unified approach, we will instead use
final_status — the property specifically designed and used by the Test
Optimization integration for this purpose.
# how to test it ?
Now more `N/A` on the last commit on this
[query](https://app.datadoghq.com/ci/test/runs?query=test_level%3Atest%20%40git.repository.id_v2%3A%2A%2Fdd-trace-rs%20%40git.branch%3Acbeauchesne%2Ffinal_status%20%40git.commit.sha%3A01dfca97ce3335fb9f346225888329ef3b1f68d8&agg_m=%40test.full_name&agg_m_source=base&agg_q=%40test.final_status&agg_q_source=base&agg_t=cardinality¤tTab=overview&eventStack=&fromUser=false&index=citest&sort_m=count&sort_m_source=base&sort_t=count&top_n=10&top_o=top&viz=timeseries&x_missing=false&start=1772906562779&end=1773165762779&paused=false)
# Additional Notes
I'm using the not-that-ideal XSLT here as this change, because it must
be done over [17+
repos](https://datadoghq.atlassian.net/browse/APMSP-2610), and it's a
workaround until this gets integrated into a better place, such as
datadog-ci or the backend.
We're trying to work with the team on this, please have a look on this
[RFC](https://docs.google.com/document/d/1OaX_h09fCXWmK_1ADrwvilt8Yt5h4WjC7UUAdS3Y3uw/edit?pli=1&tab=t.0#heading=h.tfy5viz7rz2)
for more context.1 parent f51cefc commit e9f42d8
2 files changed
Lines changed: 62 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
78 | 88 | | |
79 | 89 | | |
80 | 90 | | |
| |||
165 | 175 | | |
166 | 176 | | |
167 | 177 | | |
168 | | - | |
| 178 | + | |
169 | 179 | | |
170 | 180 | | |
171 | 181 | | |
172 | 182 | | |
173 | 183 | | |
174 | 184 | | |
175 | 185 | | |
176 | | - | |
| 186 | + | |
177 | 187 | | |
0 commit comments