nit: simplify PerTraceSettings to remove unecessary field

Author: andrewlock

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Logging/ILogger/LogsInjection/LoggerIntegrationCommon.cs

@@ -13,6 +13,7 @@ internal static class LoggerIntegrationCommon
         public const string IntegrationName = nameof(Configuration.IntegrationId.ILogger);
         private const IntegrationId IntegrationId = Configuration.IntegrationId.ILogger;
 
+        // TODO: Subscribe to changes in settings
         private static readonly DatadogLoggingScope DatadogScope = new();
 
         public static void AddScope<TAction, TState>(Tracer tracer, TAction callback, TState state)

tracer/src/Datadog.Trace/Configuration/PerTraceSettings.cs

@@ -16,11 +16,10 @@ internal class PerTraceSettings
     {
         private readonly ConcurrentDictionary<string, string> _serviceNameCache = new();
 
-        public PerTraceSettings(ITraceSampler? traceSampler, ISpanSampler? spanSampler, IReadOnlyDictionary<string, string> serviceNames, NamingSchema schema, MutableSettings mutableSettings)
+        public PerTraceSettings(ITraceSampler? traceSampler, ISpanSampler? spanSampler, NamingSchema schema, MutableSettings mutableSettings)
         {
             TraceSampler = traceSampler;
             SpanSampler = spanSampler;
-            ServiceNames = serviceNames;
             Schema = schema;
             HasResourceBasedSamplingRule = (traceSampler?.HasResourceBasedSamplingRule ?? false) || (spanSampler?.HasResourceBasedSamplingRule ?? false);
             Settings = mutableSettings;
@@ -30,7 +29,7 @@ public PerTraceSettings(ITraceSampler? traceSampler, ISpanSampler? spanSampler,
 
         public ISpanSampler? SpanSampler { get; }
 
-        public IReadOnlyDictionary<string, string> ServiceNames { get; }
+        public IReadOnlyDictionary<string, string> ServiceNames => Settings.ServiceNameMappings;
 
         public NamingSchema Schema { get; }
 

tracer/src/Datadog.Trace/TracerManager.cs

@@ -101,7 +101,7 @@ public TracerManager(
             SpanEventsManager = new SpanEventsManager(discoveryService);
 
             var schema = new NamingSchema(settings.MetadataSchemaVersion, settings.PeerServiceTagsEnabled, settings.RemoveClientServiceNamesEnabled, settings.MutableSettings.DefaultServiceName, settings.ServiceNameMappings, settings.PeerServiceNameMappings);
-            PerTraceSettings = new(traceSampler, spanSampler, settings.ServiceNameMappings, schema, settings.MutableSettings);
+            PerTraceSettings = new(traceSampler, spanSampler, schema, settings.MutableSettings);
 
             SpanContextPropagator = SpanContextPropagatorFactory.GetSpanContextPropagator(settings.PropagationStyleInject, settings.PropagationStyleExtract, settings.PropagationExtractFirstOnly, settings.PropagationBehaviorExtract);
         }