Skip to content

Commit d6988dd

Browse files
authored
John/fix-otlp-response (#969)
https://datadoghq.atlassian.net/browse/SVLS-8003 ## Overview Our extension accepts OTLP protobuf requests, and returns a json response. This break the OTLP spec - a protobuf request should have a protobuf response. See https://opentelemetry.io/docs/specs/otlp/#otlphttp-response. This PR updates our agent to return a protobuf response. ## Testing Added integration test to confirm.
1 parent 6629193 commit d6988dd

File tree

9 files changed

+300
-67
lines changed

9 files changed

+300
-67
lines changed

bottlecap/Cargo.lock

Lines changed: 61 additions & 40 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bottlecap/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ rustls-pki-types = { version = "1.0", default-features = false }
4343
hyper-rustls = { version = "0.27.7", default-features = false }
4444
rand = { version = "0.8", default-features = false }
4545
prost = { version = "0.13", default-features = false }
46+
tonic-types = { version = "0.12", default-features = false }
4647
zstd = { version = "0.13.3", default-features = false }
4748
futures = { version = "0.3.31", default-features = false }
4849
serde-aux = { version = "4.7", default-features = false }

bottlecap/LICENSE-3rdparty.csv

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ proc-macro2,https://github.com/dtolnay/proc-macro2,MIT OR Apache-2.0,"David Toln
149149
proc-macro2-diagnostics,https://github.com/SergioBenitez/proc-macro2-diagnostics,MIT OR Apache-2.0,Sergio Benitez <sb@sergio.bz>
150150
prost,https://github.com/tokio-rs/prost,Apache-2.0,"Dan Burkert <dan@danburkert.com>, Lucio Franco <luciofranco14@gmail.com>, Casper Meijn <casper@meijn.net>, Tokio Contributors <team@tokio.rs>"
151151
prost-derive,https://github.com/tokio-rs/prost,Apache-2.0,"Dan Burkert <dan@danburkert.com>, Lucio Franco <luciofranco14@gmail.com>, Casper Meijn <casper@meijn.net>, Tokio Contributors <team@tokio.rs>"
152+
prost-types,https://github.com/tokio-rs/prost,Apache-2.0,"Dan Burkert <dan@danburkert.com>, Lucio Franco <luciofranco14@gmail.com>, Casper Meijn <casper@meijn.net>, Tokio Contributors <team@tokio.rs>"
152153
protobuf,https://github.com/stepancheg/rust-protobuf,MIT,Stepan Koltsov <stepan.koltsov@gmail.com>
153154
protobuf-support,https://github.com/stepancheg/rust-protobuf,MIT,Stepan Koltsov <stepan.koltsov@gmail.com>
154155
quick-error,http://github.com/tailhook/quick-error,MIT OR Apache-2.0,"Paul Colomiets <paul@colomiets.name>, Colin Kiegel <kiegel@gmx.de>"
@@ -226,6 +227,7 @@ tokio-rustls,https://github.com/rustls/tokio-rustls,MIT OR Apache-2.0,The tokio-
226227
tokio-stream,https://github.com/tokio-rs/tokio,MIT,Tokio Contributors <team@tokio.rs>
227228
tokio-util,https://github.com/tokio-rs/tokio,MIT,Tokio Contributors <team@tokio.rs>
228229
tonic,https://github.com/hyperium/tonic,MIT,Lucio Franco <luciofranco14@gmail.com>
230+
tonic-types,https://github.com/hyperium/tonic,MIT,"Lucio Franco <luciofranco14@gmail.com>, Rafael Lemos <flemos.rafael.dev@gmail.com>"
229231
tower,https://github.com/tower-rs/tower,MIT,Tower Maintainers <team@tower-rs.com>
230232
tower-http,https://github.com/tower-rs/tower-http,MIT,Tower Maintainers <team@tower-rs.com>
231233
tower-layer,https://github.com/tower-rs/tower,MIT,Tower Maintainers <team@tower-rs.com>

0 commit comments

Comments
 (0)