Skip to content

Conversation

@L3n41c
Copy link
Member

@L3n41c L3n41c commented Oct 15, 2025

What does this PR do?

Ensure that e2e tests are using testify v1.11.1 to benefit from stretchr/testify#1427.

Motivation

With the merge of #40182, I expected the elapsed time of containers e2e tests to be significantly reduced.
Indeed, most of the tests are just waiting with an EventuallyWithT for an assertion against fake intake data to become true.
And, most of the time, the assertion should be true at the first try. So, the 10+s of elapsed for the tests was coming from the EventuallyWithT initial try.

And, according to this CI page, containers e2e tests are still lasting more than 10s despite the merge of #40182.

Describe how you validated your changes

I checked the real version of testify used by the e2e tests by:

  • starting them with: dda inv -- -e new-e2e-tests.run --targets ./tests/containers --run TestEKSSuite
  • looking for the test binary with: pstree -p $(pgrep konsole)
  • and finally checking the testify version with: strings /proc/80184/exe | grep testify | grep v1.1

Before this PR, I had:

lenaic@lenaic-Precision-5570:~$ strings /proc/80184/exe | grep testify | grep v1.1
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_compare.go
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_format.go
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_order.go
[…]

With this PR, I now have:

lenaic@lenaic-Precision-5570:~$ strings /proc/90732/exe | grep testify | grep v1.1
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_compare.go
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_format.go
/home/lenaic/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertion_order.go
[…]

Additional Notes

@L3n41c L3n41c added this to the 7.73.0 milestone Oct 15, 2025
@L3n41c L3n41c added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/container-integrations labels Oct 15, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Oct 15, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Oct 15, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 82698c0b-b743-4f6f-a0ce-982a11b71a51

Baseline: 8a8e3d2
Comparison: 9274207
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -47.75 [-49.38, -46.13] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +0.66 [-2.11, +3.44] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.51 [+0.38, +0.64] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.51 [+0.31, +0.70] 1 Logs
quality_gate_metrics_logs memory utilization +0.41 [+0.21, +0.61] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.29 [+0.12, +0.45] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.06 [+0.02, +0.11] 1 Logs
otlp_ingest_metrics memory utilization +0.06 [-0.06, +0.18] 1 Logs
ddot_metrics_sum_delta memory utilization +0.06 [-0.10, +0.22] 1 Logs
file_tree memory utilization +0.03 [-0.01, +0.08] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.03 [-0.18, +0.24] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.60, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.62, +0.58] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.63, +0.58] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.05 [-0.17, +0.06] 1 Logs
quality_gate_idle_all_features memory utilization -0.08 [-0.11, -0.04] 1 Logs bounds checks dashboard
ddot_logs memory utilization -0.11 [-0.16, -0.05] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.11 [-0.72, +0.49] 1 Logs
quality_gate_idle memory utilization -0.20 [-0.25, -0.15] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.22 [-0.29, -0.15] 1 Logs
docker_containers_memory memory utilization -2.59 [-3.02, -2.16] 1 Logs
docker_containers_cpu % cpu utilization -47.75 [-49.38, -46.13] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 8/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 15, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 8a8e3d2

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0}$$ $${675.76}$$ < $${702.15}$$ $${+0.02}$$ $${164.92}$$ < $${177.79}$$
agent_deb_amd64_fips $${-0}$$ $${670.26}$$ < $${696.65}$$ $${+0.01}$$ $${164.32}$$ < $${176.53}$$
agent_heroku_amd64 $${-0}$$ $${336.48}$$ < $${340.18}$$ $${-0}$$ $${89.82}$$ < $${91.08}$$
agent_msi $${+0}$$ $${1012.53}$$ < $${1015.38}$$ $${+0.03}$$ $${149.15}$$ < $${150.78}$$
agent_rpm_amd64 $${-0}$$ $${675.75}$$ < $${702.14}$$ $${+0.02}$$ $${167.28}$$ < $${180.53}$$
agent_rpm_amd64_fips $${-0}$$ $${670.25}$$ < $${696.64}$$ $${-0}$$ $${165.83}$$ < $${178.79}$$
agent_rpm_arm64 $${-0}$$ $${665.19}$$ < $${686.31}$$ $${+0.04}$$ $${153.44}$$ < $${161.22}$$
agent_rpm_arm64_fips $${-0}$$ $${660.71}$$ < $${681.84}$$ $${-0}$$ $${153.1}$$ < $${160.18}$$
agent_suse_amd64 $${-0}$$ $${675.75}$$ < $${702.14}$$ $${+0.02}$$ $${167.28}$$ < $${180.53}$$
agent_suse_amd64_fips $${-0}$$ $${670.25}$$ < $${696.64}$$ $${-0}$$ $${165.83}$$ < $${178.79}$$
agent_suse_arm64 $${-0}$$ $${665.19}$$ < $${686.31}$$ $${+0.04}$$ $${153.44}$$ < $${161.22}$$
agent_suse_arm64_fips $${-0}$$ $${660.71}$$ < $${681.84}$$ $${-0}$$ $${153.1}$$ < $${160.18}$$
docker_agent_amd64 $${-0}$$ $${747.19}$$ < $${773.59}$$ $${-0}$$ $${252.25}$$ < $${266.06}$$
docker_agent_arm64 $${-0}$$ $${760.58}$$ < $${781.7}$$ $${-0}$$ $${242.83}$$ < $${251.85}$$
docker_agent_jmx_amd64 $${-0}$$ $${938.06}$$ < $${964.45}$$ $${-0}$$ $${320.86}$$ < $${334.68}$$
docker_agent_jmx_arm64 $${-0}$$ $${940.05}$$ < $${961.17}$$ $${-0}$$ $${307.46}$$ < $${316.44}$$
docker_cluster_agent_amd64 $${-0}$$ $${212.95}$$ < $${213.74}$$ $${-0}$$ $${72.25}$$ < $${73.14}$$
docker_cluster_agent_arm64 $${+0}$$ $${228.86}$$ < $${229.68}$$ $${+0}$$ $${68.51}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.4}$$ < $${39.3}$$ $${+0}$$ $${14.83}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.06}$$ < $${37.94}$$ $${-0}$$ $${14.27}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.63}$$ < $${30.53}$$ $${-0}$$ $${7.81}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.21}$$ < $${29.11}$$ $${+0}$$ $${6.76}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.63}$$ < $${30.53}$$ $${-0}$$ $${7.82}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.63}$$ < $${30.53}$$ $${-0}$$ $${7.82}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${41.83}$$ < $${54.97}$$ $${+0}$$ $${10.88}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${39.65}$$ < $${51.9}$$ $${-0}$$ $${9.39}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${39.52}$$ < $${51.84}$$ $${-0}$$ $${9.48}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${41.83}$$ < $${54.97}$$ $${-0}$$ $${10.9}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${41.83}$$ < $${54.97}$$ $${-0}$$ $${10.9}$$ < $${14.47}$$

@L3n41c
Copy link
Member Author

L3n41c commented Oct 15, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 15, 2025

View all feedbacks in Devflow UI.

2025-10-15 16:36:08 UTC ℹ️ Start processing command /merge


2025-10-15 16:36:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-10-15 16:53:43 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 46m (p90).


2025-10-15 17:19:42 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2828d50 into main Oct 15, 2025
467 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lenaic/ACIX-835 branch October 15, 2025 17:19
KevinFairise2 added a commit that referenced this pull request Oct 16, 2025
KevinFairise2 added a commit that referenced this pull request Oct 16, 2025
dd-mergequeue bot pushed a commit that referenced this pull request Oct 20, 2025
This reverts commit aa9e94f.

### What does this PR do?

Re-apply #41981 and fix the tests that it broke.

### Motivation

Same as #41981: speed up tests execution thanks to stretchr/testify#1427 that makes `require.EventuallyWithT` test the condition immediately instead of waiting for an initial delay before making the very first try.

### Describe how you validated your changes

Launched a [full pipeline](https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/79481153) to be sure to run all the tests and not a subset of them: #42020 (comment)

### Additional Notes

The main feature we were looking for by upgrading `testify` to `v1.11.1` was the fact that that `require.EventuallyWithT` is now evaluating the condition the first time immediately instead of waiting for a `tick` delay before making the first try.
This unexpectedly broke the tests that are touched in this PR.
Fixing tests by adding a `time.Sleep(…)` is most probably not the smartest way of fixing them. But it restores the execution time flow of the previous versions of `testify` that happened to make the tests pass.

Co-authored-by: guyarb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/container-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants