Skip to content

Conversation

@edznux-dd
Copy link
Contributor

@edznux-dd edznux-dd commented Oct 13, 2025

What does this PR do?

This improve the fuzz_infra.py script to handle ctx.run throws that we encountered in this job:
https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1175663441

That made the list of fuzzer to be started truncated to the first crashing build.

This also adds the nvml tag to build some new targets. (TODO: how can we automate the list of tags to include "everything" ? Now that we can fail a build safely, should we "add them all" ?)

And finally, there's a small improvements on the naming scheme for Go fuzzer: the function name is now part of the package. This creates duplicate binaries, but if a package has multiple fuzzers, we can now run them properly (i.e: with their own inputs/crash/coverage)

Motivation

Improve the fuzzing infrastructure error handling and improve coverage

Describe how you validated your changes

Gitlab run with the build failure not blocking the remaining fuzzers: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1175824522

Additional Notes

N/A

@github-actions github-actions bot added team/agent-devx short review PR is simple enough to be reviewed quickly labels Oct 13, 2025
@edznux-dd edznux-dd added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Oct 13, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Oct 13, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 49c19459-16d8-4550-bb3a-adb4da2c3d43

Baseline: ca305f0
Comparison: 41c0604
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_memory memory utilization -7.65 [-8.05, -7.26] 1 Logs

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -13.94 [-15.89, -11.99] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
ddot_metrics_sum_delta memory utilization +0.30 [+0.15, +0.45] 1 Logs
quality_gate_idle_all_features memory utilization +0.27 [+0.23, +0.31] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.17 [+0.12, +0.23] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.09 [-0.54, +0.71] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.59, +0.74] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.03 [-0.21, +0.27] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.01 [-0.04, +0.05] 1 Logs
ddot_metrics memory utilization +0.01 [-0.18, +0.19] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
quality_gate_metrics_logs memory utilization -0.06 [-0.25, +0.14] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput -0.07 [-0.67, +0.53] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.07 [-0.68, +0.53] 1 Logs
otlp_ingest_logs memory utilization -0.08 [-0.21, +0.05] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.14 [-0.34, +0.06] 1 Logs
quality_gate_idle memory utilization -0.15 [-0.19, -0.11] 1 Logs bounds checks dashboard
file_tree memory utilization -0.19 [-0.23, -0.15] 1 Logs
otlp_ingest_metrics memory utilization -0.45 [-0.57, -0.33] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.47 [-0.60, -0.34] 1 Logs
quality_gate_logs % cpu utilization -0.69 [-3.46, +2.08] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.03 [-1.11, -0.95] 1 Logs
docker_containers_memory memory utilization -7.65 [-8.05, -7.26] 1 Logs
docker_containers_cpu % cpu utilization -13.94 [-15.89, -11.99] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 13, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ca305f0

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${676.04}$$ < $${702.15}$$ $${-0.01}$$ $${164.94}$$ < $${177.79}$$
agent_deb_amd64_fips $${0}$$ $${670.54}$$ < $${696.65}$$ $${+0.03}$$ $${164.22}$$ < $${176.53}$$
agent_heroku_amd64 $${0}$$ $${336.43}$$ < $${340.18}$$ $${+0}$$ $${89.81}$$ < $${91.08}$$
agent_msi $${0}$$ $${1012.52}$$ < $${1015.38}$$ $${0}$$ $${149.12}$$ < $${150.78}$$
agent_rpm_amd64 $${0}$$ $${676.03}$$ < $${702.14}$$ $${-0.01}$$ $${167.24}$$ < $${180.53}$$
agent_rpm_amd64_fips $${0}$$ $${670.53}$$ < $${696.64}$$ $${+0}$$ $${165.82}$$ < $${178.79}$$
agent_rpm_arm64 $${0}$$ $${665.46}$$ < $${686.31}$$ $${+0.06}$$ $${153.49}$$ < $${161.22}$$
agent_rpm_arm64_fips $${0}$$ $${661.05}$$ < $${681.84}$$ $${+0.01}$$ $${153.05}$$ < $${160.18}$$
agent_suse_amd64 $${0}$$ $${676.03}$$ < $${702.14}$$ $${-0.01}$$ $${167.24}$$ < $${180.53}$$
agent_suse_amd64_fips $${0}$$ $${670.53}$$ < $${696.64}$$ $${+0}$$ $${165.82}$$ < $${178.79}$$
agent_suse_arm64 $${0}$$ $${665.46}$$ < $${686.31}$$ $${+0.06}$$ $${153.49}$$ < $${161.22}$$
agent_suse_arm64_fips $${0}$$ $${661.05}$$ < $${681.84}$$ $${+0.01}$$ $${153.05}$$ < $${160.18}$$
docker_agent_amd64 $${+0}$$ $${747.47}$$ < $${773.59}$$ $${+0}$$ $${252.3}$$ < $${266.06}$$
docker_agent_arm64 $${+0}$$ $${760.85}$$ < $${781.7}$$ $${+0}$$ $${242.9}$$ < $${251.85}$$
docker_agent_jmx_amd64 $${0}$$ $${938.34}$$ < $${964.45}$$ $${+0}$$ $${320.93}$$ < $${334.68}$$
docker_agent_jmx_arm64 $${-0}$$ $${940.32}$$ < $${961.17}$$ $${+0}$$ $${307.51}$$ < $${316.44}$$
docker_cluster_agent_amd64 $${-0}$$ $${212.97}$$ < $${213.74}$$ $${+0}$$ $${72.24}$$ < $${73.14}$$
docker_cluster_agent_arm64 $${0}$$ $${228.92}$$ < $${229.68}$$ $${-0}$$ $${68.51}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.41}$$ < $${39.3}$$ $${+0}$$ $${14.83}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.06}$$ < $${37.94}$$ $${-0}$$ $${14.28}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.64}$$ < $${30.53}$$ $${+0}$$ $${7.81}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.22}$$ < $${29.11}$$ $${-0}$$ $${6.77}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.64}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.64}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${51.42}$$ < $${54.97}$$ $${-0}$$ $${12.98}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${48.81}$$ < $${51.9}$$ $${+0}$$ $${11.27}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${48.39}$$ < $${51.84}$$ $${+0}$$ $${11.26}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${51.42}$$ < $${54.97}$$ $${-0.01}$$ $${12.99}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${51.42}$$ < $${54.97}$$ $${-0.01}$$ $${12.99}$$ < $${14.47}$$

@edznux-dd edznux-dd marked this pull request as ready for review October 13, 2025 09:58
@edznux-dd edznux-dd requested a review from a team as a code owner October 13, 2025 09:58
Copy link
Member

@chouetz chouetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only, LGTM


# Map the owner to a slack channel
return GITHUB_SLACK_MAP.get(first_owner, DEFAULT_FUZZING_SLACK_CHANNEL)
return GITHUB_SLACK_MAP.get(first_owner, DEFAULT_FUZZING_SLACK_CHANNEL).replace("#", "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you confirm this is necessary? I think both can work when calling the slack api.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is forwarded to workflow automation, and as of today, it's not handling it very well.
We plan to also clean that up on the api side, but that's a safe cleanup to do here.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Oct 13, 2025
Co-authored-by: Nicolas Schweitzer <[email protected]>
@edznux-dd
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 13, 2025

View all feedbacks in Devflow UI.

2025-10-13 12:48:47 UTC ℹ️ Start processing command /merge


2025-10-13 12:48:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-10-13 14:31:14 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 40m (p90).


2025-10-13 14:46:49 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 039af8b into main Oct 13, 2025
250 checks passed
@dd-mergequeue dd-mergequeue bot deleted the edouard/upgrade-fuzz-infra-script-handle-errors branch October 13, 2025 14:46
@github-actions github-actions bot added this to the 7.73.0 milestone Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants