Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@
"react-helmet": "^6.1.0",
"react-icons": "^2.2.7",
"react-input-autosize": "^2.2.1",
"react-instantsearch": "^5.7.0",
"react-instantsearch": "^6.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to react-instantsearch v6.0.0 is a major version change that introduces breaking changes. The application code and other dependencies must be updated for compatibility.

  1. Code changes required: The import paths for react-instantsearch components have changed. Imports from 'react-instantsearch/dom' must be updated to 'react-instantsearch'. Files like src/app/pages/Search/index.tsx and src/app/pages/Search/Results/index.js are affected. Without these changes, the application will fail to build or run.

  2. Outdated type definitions: The @types/react-instantsearch package in devDependencies (line 296) is for v5 and is now incompatible. react-instantsearch v6 includes its own TypeScript definitions, so @types/react-instantsearch should be removed.

  3. yarn.lock update: As mentioned in the PR description, the yarn.lock file needs to be updated by running yarn and committing the resulting changes.

"react-loadable": "^3.3.1",
"react-markdown": "^5.0.0",
"react-media": "^1.10.0",
Expand Down
Loading