forked from codesandbox/codesandbox-client
-
-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade react-instantsearch from 5.7.0 to 6.0.0 #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dargon789
wants to merge
1
commit into
main
Choose a base branch
from
snyk-fix-2462cd4beba9117407fd7f7d22a3b44a
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to
react-instantsearchv6.0.0 is a major version change that introduces breaking changes. The application code and other dependencies must be updated for compatibility.Code changes required: The import paths for
react-instantsearchcomponents have changed. Imports from'react-instantsearch/dom'must be updated to'react-instantsearch'. Files likesrc/app/pages/Search/index.tsxandsrc/app/pages/Search/Results/index.jsare affected. Without these changes, the application will fail to build or run.Outdated type definitions: The
@types/react-instantsearchpackage indevDependencies(line 296) is for v5 and is now incompatible.react-instantsearchv6 includes its own TypeScript definitions, so@types/react-instantsearchshould be removed.yarn.lockupdate: As mentioned in the PR description, theyarn.lockfile needs to be updated by runningyarnand committing the resulting changes.