You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6d48ef6
Browse filesBrowse the repository at this point in the historyBrowse files
Re-enable DateOnly/TimeOnly support, fixing the defects that got it disabled (#2228)
DateOnly/TimeOnly support (#2051) was compiled out in 907a4d9 pending
#2071/#2072. This re-enables it with the root causes fixed, and teaches the
read paths that the date/time family has no IConvertible bridge - which box
a date or time column yields is a provider/version decision (Npgsql 10:
DateOnly/TimeOnly; SqlClient and Npgsql 9: DateTime/TimeSpan), so both
shapes must convert:
- GetFieldValue<T> is no longer demanded of a column whose reported type
needs a family conversion (a datetime column into a DateOnly member was
the #2072 breakage; SqlDecimal-style entries, where GetFieldValue from a
differently-reported column is the whole point, keep it);
- the member, scalar and Parse<T> paths all convert DateOnly/TimeOnly <->
DateTime/TimeSpan in both directions (IL for members, object-level
elsewhere), fixing reads against Npgsql 10 date/time columns (#2226);
- Query<DateOnly>/<TimeOnly> in scalar form no longer silently return
default(T) (#2227): the typeMap entries make them simple types again;
- the same-TypeCode direct-unbox shortcut is restricted to distinct codes:
TypeCode.Object matching TypeCode.Object says nothing (TimeSpan into
TimeOnly? threw), while object on either side (sql_variant columns,
dynamic members) keeps the direct unbox;
- the scalar conversion fallback keeps Convert.ChangeType's strict null
contract (TestConversionExceptionMessages pins it).
The parked DateTimeOnlyTests are re-enabled, with new tests for the #2072
shape (datetime column into DateOnly member), the #2227 scalar shape, and
date-as-DateTime regression guards; PostgresqlTests gains the Npgsql-10
interchange matrix ([FactPostgresql], so it runs where the documented
container is available).
Fixes#2072, #2226, #2227, #1728; expected to also resolve#2071.
[Fact]// #2072: a datetime column into a DateOnly member - the provider boxes DateTime,
86
+
// so this must convert rather than demand GetFieldValue<DateOnly> of a datetime column
87
+
publicvoidMembersFromDateTimeAndTimeSpanColumns()
88
+
{
89
+
varrow=connection.QuerySingle<HazDateTimeOnly>(
90
+
"select 'x' as [Name], cast('2019-10-01' as datetime) as [Date], cast('03:03:03' as time) as [Time], cast('2019-10-02' as datetime) as [NDate], cast('04:04:04' as time) as [NTime]");
91
+
Assert.Equal(newDateOnly(2019,10,1),row.Date);
92
+
Assert.Equal(newTimeOnly(3,3,3),row.Time);
93
+
Assert.Equal(newDateOnly(2019,10,2),row.NDate);
94
+
Assert.Equal(newTimeOnly(4,4,4),row.NTime);
95
+
}
96
+
97
+
[Fact]// #2227: the scalar form must not silently yield default(T)
98
+
publicvoidScalarDateOnlyAndTimeOnly()
99
+
{
100
+
Assert.Equal(newDateOnly(2021,1,1),connection.QuerySingle<DateOnly>("select cast('2021-01-01' as date)"));
101
+
Assert.Equal(newTimeOnly(3,3,3),connection.QuerySingle<TimeOnly>("select cast('03:03:03' as time)"));
102
+
Assert.Equal(newDateOnly(2021,1,1),connection.QuerySingle<DateOnly?>("select cast('2021-01-01' as date)"));
103
+
}
104
+
105
+
[Fact]// the pre-DateOnly reading of a date column must keep working
106
+
publicvoidDateColumnAsDateTime()
107
+
{
108
+
Assert.Equal(newDateTime(2021,1,1),connection.QuerySingle<DateTime>("select cast('2021-01-01' as date)"));
109
+
Assert.Equal(newDateTime(2021,1,1),connection.QuerySingle<HazDateTime>("select cast('2021-01-01' as date) as [When]").When);
0 commit comments