fix: Minor fixes, and testing pilot summary

Author: Robin VAN DE MERGHEL

diracx-logic/src/diracx/logic/pilots/management.py

@@ -24,7 +24,7 @@ async def register_new_pilots(
     status: str,
     pilot_job_references: dict[str, str] | None,
 ):
-    # [IMPORTANT] Check unicity of pilot references
+    # [IMPORTANT] Check unicity of pilot stamps
     # If a pilot already exists, we raise an error (transaction will rollback)
     existing_pilots = await get_pilots_by_stamp(
         pilot_db=pilot_db, pilot_stamps=pilot_stamps

diracx-routers/src/diracx/routers/pilots/management.py

@@ -208,7 +208,7 @@ async def update_pilot_fields(
 
     # Prevent someone who stole a pilot X509 to modify thousands of pilots at a time
     # (It would be still able to modify thousands of pilots, but slower)
-    # We are not able to affirm that this pilots modifies itself
+    # We are not able to affirm that this pilot modifies itself
     if GENERIC_PILOT in user_info.properties:
         if len(pilot_stamps) != 1:
             raise HTTPException(

diracx-routers/src/diracx/routers/pilots/query.py

@@ -156,7 +156,6 @@ async def summary(
     check_permissions: CheckPilotManagementPolicyCallable,
 ):
     """Show information suitable for plotting."""
-    # TODO: Test me.
     await check_permissions(action=ActionType.READ_PILOT_FIELDS)
 
     return await summary_bl(

diracx-routers/tests/pilots/test_query.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import pytest
+from fastapi.testclient import TestClient
 
 from diracx.core.exceptions import InvalidQueryError
 from diracx.core.models import (
@@ -82,6 +83,48 @@ async def populated_pilot_client(normal_test_client):
     yield normal_test_client
 
 
+async def test_pilot_summary(populated_pilot_client: TestClient):
+    # Group by StatusReason
+    r = populated_pilot_client.post(
+        "/api/pilots/summary",
+        json={
+            "grouping": ["StatusReason"],
+        },
+    )
+
+    assert r.status_code == 200
+
+    assert sum([el["count"] for el in r.json()]) == N
+    assert len(r.json()) == len(PILOT_REASONS)
+
+    # Group by CurrentJobID
+    r = populated_pilot_client.post(
+        "/api/pilots/summary",
+        json={
+            "grouping": ["CurrentJobID"],
+        },
+    )
+
+    assert r.status_code == 200
+
+    assert all(el["count"] == 1 for el in r.json())
+    assert len(r.json()) == N
+
+    # Group by CurrentJobID where BenchMark < 10^2
+    r = populated_pilot_client.post(
+        "/api/pilots/summary",
+        json={
+            "grouping": ["CurrentJobID"],
+            "search": [{"parameter": "BenchMark", "operator": "lt", "value": 10**2}],
+        },
+    )
+
+    assert r.status_code == 200, r.json()
+
+    assert all(el["count"] == 1 for el in r.json())
+    assert len(r.json()) == 10
+
+
 @pytest.fixture
 async def search(populated_pilot_client):
     async def _search(