Add Missing Annotations to filter based on spec #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-zepol
force-pushed
the
missing_annotations
branch
from
87a6ee1 to
f7ece41
Compare
mr-zepol
force-pushed
the
missing_annotations
branch
from
f7ece41 to
80a5656
Compare
Member
|
Looks good, but merging of the other PRs caused a merge conflict. Happy to approve once the conflict is resolved 👌 |
Signed-off-by: Alex Alzate <[email protected]>
mr-zepol
force-pushed
the
missing_annotations
branch
from
80a5656 to
60cde08
Compare
Contributor
Author
Fixed |
nscuro
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing annotations for different attributes based on the spec