Skip to content

Double inline styles applied for Vimeo player #609

Description

@yhattav

Current Behavior

example - <ReactPlayer style = {{translate: 'transform (50%,50%,0px)'}} />
style is applied once on the reactPlayer root div. and then again in the Vimeo.js file to the first div.

const style = {
      width: '100%',
      height: '100%',
      overflow: 'hidden',
      backgroundColor: 'black',
     **...this.props.style**
    }
    return (
      <div
        key={this.props.url}
        ref={this.ref}
        style={style}
      />
    )

Expected Behavior

the styles should be applied only on the root div (this is what the readme states).

Other Information

some css like hight / width applied to parent and child div are not creating bugs because its just forcing the same height and its not visible (height is defined inline as 100% for Vimeo anyway). but other css like the transform3d is destructive when applied twice on top of eachother.
I created this fiddle to show what i mean:
fiddle

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions