[Stateless Proto] Introducing execution proofs subnet and gossip validation #9869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…port any milestone Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
# Conflicts: # ethereum/spec/src/main/java/tech/pegasys/teku/spec/schemas/registry/SchemaRegistryBuilder.java
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
# Conflicts: # teku/src/test/java/tech/pegasys/teku/cli/options/ZkChainOptionsTest.java
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/Eth2P2PNetworkBuilder.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/Eth2P2PNetworkBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
| public static ExecutionProofGossipValidator create() { | ||
| return new ExecutionProofGossipValidator( | ||
| // max subnets * 2 epochs * slots per epoch 32 based on mainnet for now | ||
| LimitedSet.createSynchronized(MAX_EXECUTION_PROOF_SUBNETS.intValue() * 64)); |
There was a problem hiding this comment.
Bug: Cache Size Miscalculation in Epoch-Specific Code
The LimitedSet size calculation in ExecutionProofGossipValidator hardcodes 64 for slots per epoch. This value is mainnet-specific and doesn't adapt to different network configurations, potentially leading to incorrect cache sizing.
| topics.add(getExecutionProofSubnetTopic(forkDigest, i, gossipEncoding)); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Bug: Method Signature Change Causes Compatibility Issues
Adding a P2PConfig parameter to the GossipTopics.getAllTopics method signature breaks existing call sites. This results in compilation errors or incorrect behavior where callers haven't been updated.
...eth2/src/main/java/tech/pegasys/teku/networking/eth2/gossip/ExecutionProofGossipManager.java
Dismissed
Show dismissed
Hide dismissed
gfukushima
changed the title
lucassaldanha
approved these changes
Oct 8, 2025
# Conflicts: # networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/Eth2P2PNetworkBuilder.java # networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/gossip/forks/GossipForkSubscriptions.java # networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/gossip/forks/versions/GossipForkSubscriptionsGloas.java # networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/gossip/forks/versions/GossipForkSubscriptionsGloasBpo.java # networking/eth2/src/testFixtures/java/tech/pegasys/teku/networking/eth2/Eth2P2PNetworkFactory.java
Signed-off-by: Gabriel Fukushima <[email protected]>
| topics.add(getExecutionProofSubnetTopic(forkDigest, i, gossipEncoding)); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Bug: Method Update Causes Compilation Failures
The getAllTopics method signature was updated to include a P2PConfig parameter, but not all existing call sites, like those in Eth2GossipTopicFilter.java, were updated to pass this new parameter. This leads to compilation errors.
| return new ExecutionProofGossipValidator( | ||
| // max subnets * 2 epochs * slots per epoch 32 based on mainnet for now | ||
| LimitedSet.createSynchronized(MAX_EXECUTION_PROOF_SUBNETS.intValue() * 64)); | ||
| } |
There was a problem hiding this comment.
Bug: Code-Comment Mismatch in LimitedSet Size Calculation
The LimitedSet size is calculated as MAX_EXECUTION_PROOF_SUBNETS.intValue() * 64, but the accompanying comment describes a different calculation: max subnets * 2 epochs * 32 slots per epoch. This creates a discrepancy between the code and its documentation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Added some initial boiler plate to get the execution proof subnet in and start in the controler when the statelss flag is enabled
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Introduces execution proof gossip (topics, subnets, manager/validator) and CLI/config flag to enable it, with networking and controller wiring to process and publish proofs.
execution_proof_<subnet>), subnet subscriptions,ExecutionProofGossipManager,ExecutionProofSubnetSubscriptions, and topic handler.GossipForkSubscriptions*andGossipForkManagerto publish/subscribe execution proofs; include in Electra/Fulu/Gloas (and BPO) subscriptions.Eth2P2PNetwork/ActiveEth2P2PNetworkto support exec-proof subnet subscribe/unsubscribe and publish viaExecutionProofGossipChannel.P2PConfig/--Xexecution-proof-topics-enabled.GossipTopics/GossipTopicNameupdated to generate execution proof topics.ExecutionProofManager(+ impl) andExecutionProofGossipValidatorto validate and track received proofs; listener subscription API.ExecutionProofManagerinBeaconChainController(gated byZkChainConfiguration), subscribe to valid proofs, and expose processor to P2P builder.P2PConfiggainsexecutionProofTopicEnabled(default off) and builder/plumbing; new CLI flag--Xexecution-proof-topics-enabled.Written by Cursor Bugbot for commit 837da57. This will update automatically on new commits. Configure here.