completed book-library debugging

Author: TzeMingHo

debugging/book-library/index.html

@@ -51,6 +51,7 @@ <h1>Library</h1>
           class="form-control"
           id="pages"
           name="pages"
+          min="1"
           required
         />
         <label class="form-check-label">
@@ -91,6 +92,6 @@ <h1>Library</h1>
       </tbody>
     </table>
 
-    <script src="script.js"></script>
+    <script src="script.js" defer></script>
   </body>
 </html>

debugging/book-library/script.js

@@ -7,7 +7,7 @@ window.addEventListener("load", function (e) {
 
 function populateStorage() {
   if (myLibrary.length == 0) {
-    let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
+    let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true);
     let book2 = new Book(
       "The Old Man and the Sea",
       "Ernest Hemingway",
@@ -29,20 +29,27 @@ const check = document.getElementById("check");
 //via Book function and start render function
 function submit() {
   if (
-    title.value == null ||
-    title.value == "" ||
-    pages.value == null ||
-    pages.value == ""
+    !title.value.trim() ||
+    !author.value.trim() ||
+    !pages.value
   ) {
     alert("Please fill all fields!");
     return false;
   } else {
-    let book = new Book(title.value, title.value, pages.value, check.checked);
-    library.push(book);
+    let book = new Book(title.value, author.value, pages.value, check.checked);
+    myLibrary.push(book);
+    resetAddNewBook()
     render();
   }
 }
 
+function resetAddNewBook() {
+  title.value = '';
+  author.value = '';
+  pages.value = '';
+  check.checked = false;
+}
+
 function Book(title, author, pages, check) {
   this.title = title;
   this.author = author;
@@ -54,49 +61,49 @@ function render() {
   let table = document.getElementById("display");
   let rowsNumber = table.rows.length;
   //delete old table
-  for (let n = rowsNumber - 1; n > 0; n-- {
+  for (let n = rowsNumber - 1; n > 0; n-- ){
     table.deleteRow(n);
   }
   //insert updated row and cells
   let length = myLibrary.length;
-  for (let i = 0; i < length; i++) {
-    let row = table.insertRow(1);
+  for (let libraryBookIndex = 0; libraryBookIndex < length; libraryBookIndex++) {
+    let row = table.insertRow(-1);
     let titleCell = row.insertCell(0);
     let authorCell = row.insertCell(1);
     let pagesCell = row.insertCell(2);
     let wasReadCell = row.insertCell(3);
     let deleteCell = row.insertCell(4);
-    titleCell.innerHTML = myLibrary[i].title;
-    authorCell.innerHTML = myLibrary[i].author;
-    pagesCell.innerHTML = myLibrary[i].pages;
+    titleCell.innerHTML = myLibrary[libraryBookIndex].title;
+    authorCell.innerHTML = myLibrary[libraryBookIndex].author;
+    pagesCell.innerHTML = myLibrary[libraryBookIndex].pages;
 
     //add and wait for action for read/unread button
-    let changeBut = document.createElement("button");
-    changeBut.id = i;
-    changeBut.className = "btn btn-success";
-    wasReadCell.appendChild(changeBut);
+    let readOrUnreadButton = document.createElement("button");
+    readOrUnreadButton.id = `readOrUnreadBtn${libraryBookIndex}`;
+    readOrUnreadButton.className = "btn btn-success";
+    wasReadCell.appendChild(readOrUnreadButton);
     let readStatus = "";
-    if (myLibrary[i].check == false) {
+    if (myLibrary[libraryBookIndex].check) {
       readStatus = "Yes";
     } else {
       readStatus = "No";
     }
-    changeBut.innerText = readStatus;
+    readOrUnreadButton.innerText = readStatus;
 
-    changeBut.addEventListener("click", function () {
-      myLibrary[i].check = !myLibrary[i].check;
+    readOrUnreadButton.addEventListener("click", function () {
+      myLibrary[libraryBookIndex].check = !myLibrary[libraryBookIndex].check;
       render();
     });
 
     //add delete button to every row and render again
     let delButton = document.createElement("button");
-    delBut.id = i + 5;
-    deleteCell.appendChild(delBut);
-    delBut.className = "btn btn-warning";
-    delBut.innerHTML = "Delete";
-    delBut.addEventListener("clicks", function () {
-      alert(`You've deleted title: ${myLibrary[i].title}`);
-      myLibrary.splice(i, 1);
+    delButton.id = `delBtn${libraryBookIndex}`;
+    deleteCell.appendChild(delButton);
+    delButton.className = "btn btn-warning";
+    delButton.innerHTML = "Delete";
+    delButton.addEventListener("click", () => {
+      alert(`You've deleted title: ${myLibrary[libraryBookIndex].title}`);
+      myLibrary.splice(libraryBookIndex, 1);
       render();
     });
   }