API: libcrmcommon: Deprecate crm_log_xml_trace()

nrwahl2 · nrwahl2 · commit d4a2e495a196 · 2025-11-27T13:26:47.000-08:00
Pacemaker should not be used for general-purpose logging.

Ref T622

Signed-off-by: Reid Wahl &lt;nrwahl@protonmail.com&gt;
diff --git a/include/crm/common/logging.h b/include/crm/common/logging.h
@@ -306,8 +306,6 @@ pcmk__clip_log_level(int level)
         }                                                                   \
     } while (0)
 
-#define crm_log_xml_trace(xml, text)   do_crm_log_xml(LOG_TRACE,   text, xml)
-
 #define crm_log_xml_explicit(xml, text)  do {                   \
         static struct qb_log_callsite *digest_cs = NULL;        \
         digest_cs = qb_log_callsite_get(                        \
diff --git a/include/crm/common/logging_compat.h b/include/crm/common/logging_compat.h
@@ -99,6 +99,9 @@ extern "C" {
 //! \deprecated Do not use
 #define crm_log_xml_debug(xml, text) do_crm_log_xml(LOG_DEBUG, text, xml)
 
+//! \deprecated Do not use
+#define crm_log_xml_trace(xml, text) do_crm_log_xml(LOG_TRACE, text, xml)
+
 #ifdef __cplusplus
 }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,9 @@ extern "C" {`
`99`	`99`	`//! \deprecated Do not use`
`100`	`100`	`#define crm_log_xml_debug(xml, text) do_crm_log_xml(LOG_DEBUG, text, xml)`
`101`	`101`
	`102`	`+//! \deprecated Do not use`
	`103`	`+#define crm_log_xml_trace(xml, text) do_crm_log_xml(LOG_TRACE, text, xml)`
	`104`	`+`
`102`	`105`	`#ifdef __cplusplus`
`103`	`106`	`}`
`104`	`107`	`#endif`