Skip to content

Commit df28730

Browse files
authored
Merge pull request #1704 from ClickHouse/SpencerTorres-patch-1
Update cloud version matrix (25.10)
2 parents a6d5a5f + 5c8c388 commit df28730

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

.github/workflows/run-tests.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,10 @@ jobs:
2020
- "1.25"
2121
- "1.24"
2222
clickhouse: # https://github.com/ClickHouse/ClickHouse/blob/master/SECURITY.md#scope-and-supported-versions
23-
- "25.7"
24-
- "25.6"
25-
- "25.5"
23+
- "25.10"
24+
- "25.9"
25+
- "25.8"
2626
- "25.3"
27-
- "24.8"
2827
steps:
2928
- name: Checkout
3029
uses: actions/checkout@v4

conn_http.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
package clickhouse
32

43
import (
@@ -253,6 +252,7 @@ func createHTTPRoundTripper(opt *Options) (http.RoundTripper, error) {
253252
IdleConnTimeout: opt.ConnMaxLifetime,
254253
ResponseHeaderTimeout: opt.ReadTimeout,
255254
TLSClientConfig: opt.TLS,
255+
DisableCompression: true,
256256
}
257257

258258
if opt.DialContext != nil {

conn_http_query.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
package clickhouse
32

43
import (
@@ -51,9 +50,6 @@ func (h *httpConnect) query(ctx context.Context, release nativeTransportRelease,
5150
rw := h.compressionPool.Get()
5251
// The HTTPReaderWriter.NewReader will create a reader that will decompress it if needed,
5352
// cause adding Accept-Encoding:gzip on your request means response won’t be automatically decompressed
54-
// per https://github.com/golang/go/blob/master/src/net/http/transport.go#L182-L190.
55-
// Note user will need to have set enable_http_compression for CH to respond with compressed data. we don't set this
56-
// automatically as they might not have permissions.
5753
reader, err := rw.NewReader(res)
5854
if err != nil {
5955
err = fmt.Errorf("NewReader: %w", err)

0 commit comments

Comments
 (0)