libclamav: Malformed regexes result in misleading memory error messages. #1635
+17
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex parsing code treated anything that did not return CL_SUCCESS as CL_EMEM in several places, resulting in a return code indicative of a malformed database returning a memory error instead. This change passes the real return code up the chain, and also prevents trying to realloc 0 bytes when we don't have anything to realloc due to a malformed database. CLAM-2191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex parsing code converted the return code of anything that did not return CL_SUCCESS to CL_EMEM in several places, resulting in a return code indicative of a malformed database returning a memory error instead. This change passes the real return code up the chain and also prevents trying to realloc 0 bytes when we don't have anything to realloc due to a malformed database.
CLAM-2191