Resolve incompatible-pointer-types #1372
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val-ms
requested changes
Dec 17, 2024
libclamav/regex/engine.c
Outdated
| } else { | ||
| if (g->nplus > 0 && m->lastpos == NULL) | ||
| m->lastpos = (char **)cli_max_malloc((g->nplus+1) * | ||
| m->lastpos = (const char **)cli_max_malloc((g->nplus+1) * |
Contributor
There was a problem hiding this comment.
It feels like the correct fix is to remove const in the lastpos definition. Check out the warnings in the "Files Changed" tab.
Contributor
There was a problem hiding this comment.
Well now I'm confused. Now I see issues because sp is declared as const char *sp;
It looks like that was intended to be an improvement with an upgrade to the newer version of the regex module as well: 87cdd70
Perhaps we should cast like:
m->lastpos[lev] = (char *)sp;
(and for the second one)
What do you think @Kangie ?
Drop `const` in the `lastpos` definition to resolve `incompatbile-pointer-types` warnings (errors in modern compilers). Signed-off-by: Matt Jolly <[email protected]>
Contributor
Author
|
Fixed, thanks. |
Contributor
Author
|
test failure seems unrelated; it's in rust code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly cast regex match to
const char **; we don't modify the value once it's set like this; we should be safe.