feat: add validation for values of step rerun fields - #350
Merged
Conversation
stig
approved these changes
Aug 26, 2025
SashaLsnko
force-pushed
the
add-more-validation-to-step-reruns
branch
from
August 26, 2025 17:36
50bdb29 to
30ba354
Compare
Contributor
Author
|
I updated the code to only allow delay value as minutes OR seconds |
briceicle
approved these changes
Aug 26, 2025
SashaLsnko
force-pushed
the
add-more-validation-to-step-reruns
branch
from
August 26, 2025 18:43
30ba354 to
d656900
Compare
briceicle
approved these changes
Aug 26, 2025
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
Description
Add validation for step rerun fields:
max_auto_reruns- value is between 1 and 5auto_rerun_delay- value should be in a duration format, not longer than 10 minutes, and should conform to(10|[1-9])m|([1-9][0-9]*)sregex (be in the form of either minutes or seconds)How to validate
unit tests