fix: remove false positive of unused jobs - #275
Merged
Conversation
JulesFaucherre
changed the title
JulesFaucherre
force-pushed
the
local-orbs-go-to-definition
branch
from
February 6, 2024 15:20
43d9397 to
a399d77
Compare
JulesFaucherre
force-pushed
the
fix-job-unused-for-local-orbs
branch
from
February 6, 2024 15:53
a976f28 to
20e70a2
Compare
loderunner
previously approved these changes
Feb 6, 2024
JulesFaucherre
force-pushed
the
local-orbs-go-to-definition
branch
from
February 6, 2024 16:16
a399d77 to
42da6f8
Compare
JulesFaucherre
dismissed
loderunner’s stale review
February 6, 2024 16:19
The base branch was changed.
JulesFaucherre
force-pushed
the
fix-job-unused-for-local-orbs
branch
from
February 6, 2024 16:20
20e70a2 to
725b69b
Compare
JulesFaucherre
enabled auto-merge (squash)
February 6, 2024 16:20
JulesFaucherre
force-pushed
the
fix-job-unused-for-local-orbs
branch
from
February 20, 2024 14:50
725b69b to
fedfb1b
Compare
loderunner
approved these changes
Feb 20, 2024
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: None
Description
Removes
"Job is unused"diagnostic from used local orb jobs.Implementation details
When running a validation, sub-validations are run for each local orb, considering the local orb as a document on its own. Since jobs were not used in the context of this local orb sub document, a diagnostic of
"Job is unused"was set.To address this issue,
Job is unusedandCommand is unusedare not evaluated when validating a local orb.Took advantage of this PR to also reduce the validation that was done for local orbs.
How to validate
Wrote tests but don't hesitate to write your own file with a local orb that have jobs and make sure they don't have the diagnostic.