feat: update getHistoricalSummaries endpoint include version+slot

[KolbyML]

Motivation

This PR is an extension on #7245

I was trying to use the endpoint to create a https://github.com/ethereum/portal-network-specs/blob/master/beacon-chain/beacon-network.md#historicalsummaries HistoricalSummariesWithProof, but the endpoint didn't return the Fork or the slot as we need the epoch.

Description

• I added slot to the HistoricalSummariesResponseType type
• I used ExecutionOptimisticFinalizedAndVersionCodec to expose the fork
• I changed /eth/v1/lodestar/historical_summaries/{state_id} to /eth/v1/lodestar/states/{state_id}/historical_summaries to be more in line with the other state endpoints https://ethereum.github.io/beacon-APIs/#/Beacon

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nflaig
❌ KolbyML
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[KolbyML]

@nflaig ready for another look 🚀

[nflaig]

LGTM

[nflaig]

need to update unit test https://github.com/ChainSafe/lodestar/actions/runs/14637839899/job/41075692517#step:5:2973

[nflaig]

I was trying to use the endpoint to create a https://github.com/ethereum/portal-network-specs/blob/master/beacon-chain/beacon-network.md#historicalsummaries HistoricalSummariesWithProof, but the endpoint didn't return the Fork or the slot as we need the epoch.

does it make sense to return epoch instead of slot directly from the api?

[KolbyML]

I was trying to use the endpoint to create a https://github.com/ethereum/portal-network-specs/blob/master/beacon-chain/beacon-network.md#historicalsummaries HistoricalSummariesWithProof, but the endpoint didn't return the Fork or the slot as we need the epoch.

does it make sense to return epoch instead of slot directly from the api?

I will fix the test tomorrow, I was trying to match status-im/nimbus-eth2#6675 Nimbus's implementation to a degree. I struggle reading Nim. But without the slot/epoch and fork info it is awkward to use Lodestar's current api for our usecase. We can easily derive the epoch ourselves so I think it is fine if we keep it as a slot.

[nflaig]

We can easily derive the epoch ourselves so I think it is fine if we keep it as a slot.

Whatever works best for you, I don't think anyone else is using the api

[codecov]

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.29%. Comparing base (dd729f5) to head (a07bc54).
Report is 2 commits behind head on unstable.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #7742      +/-   ##
============================================
- Coverage     56.29%   56.29%   -0.01%     
============================================
  Files           837      837              
  Lines         58044    58048       +4     
  Branches       4469     4468       -1     
============================================
- Hits          32678    32677       -1     
- Misses        25298    25303       +5     
  Partials         68       68              

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[KolbyML]

It looks like you updated the test yourself, is there anything else I need to do on my end?

[nflaig]

It looks like you updated the test yourself, is there anything else I need to do on my end?

seems good to me, CI is happy as well now

[nflaig]

merging this, can do follow up changes if something still needs to be adapted

[wemeetagain]

🎉 This PR is included in v1.30.0 🎉