Feature/user models #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XanderVertegaal
changed the base branch from
develop
to
feature/user-problems
jgonggrijp
reviewed
Nov 20, 2025
Contributor
jgonggrijp
left a comment
jgonggrijp
left a comment
There was a problem hiding this comment.
#12 has a table of permissions that each role should or should not have. Why not just define those as custom permissions (where needed) and then implement the roles as regular user groups? That way you don't have to hardcode the roles and Django will assist more in enforcing the permissions.
Comment on lines
+17
to
+21
| class Role(models.TextChoices): | ||
| ANNOTATOR = "annotator", "Annotator" | ||
| MASTER_ANNOTATOR = "master_annotator", "Master Annotator" | ||
| VISITOR = "visitor", "Visitor" | ||
|
|
Contributor
There was a problem hiding this comment.
Aren't you basically reinventing and hardcoding user groups here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #12
Adds a
rolefield to the User model. I opted to add a fieldcanEditOrAddProblemto the serializer so we don't have to implement a method that checks whether a user with role X can do Y in two places.