Skip to content

Conversation

@ss2165
Copy link
Member

@ss2165 ss2165 commented Nov 20, 2025

Before registration would not have happened for model_ast imports

@ss2165 ss2165 requested a review from a team as a code owner November 20, 2025 12:21
@ss2165 ss2165 requested a review from doug-q November 20, 2025 12:21
@ss2165 ss2165 changed the title fix: register packaged extensions before model import fix: register packaged extensions before model_ast import Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.36%. Comparing base (6ea4abf) to head (60d9efc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2702   +/-   ##
=======================================
  Coverage   83.35%   83.36%           
=======================================
  Files         267      267           
  Lines       52479    52503   +24     
  Branches    47190    47214   +24     
=======================================
+ Hits        43746    43770   +24     
  Misses       6355     6355           
  Partials     2378     2378           
Flag Coverage Δ
python 88.75% <ø> (ø)
rust 82.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to write a test for this?

@ss2165 ss2165 force-pushed the ss/push-mvxwoulztwmk branch from 9c92578 to 60d9efc Compare December 1, 2025 11:57
@ss2165
Copy link
Member Author

ss2165 commented Dec 1, 2025

yes done

@ss2165 ss2165 requested a review from doug-q December 1, 2025 11:58
Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ss2165 ss2165 enabled auto-merge December 1, 2025 12:00
@ss2165 ss2165 added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit 9508ad1 Dec 1, 2025
30 checks passed
@ss2165 ss2165 deleted the ss/push-mvxwoulztwmk branch December 1, 2025 12:07
@hugrbot hugrbot mentioned this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants