Skip to content

Commit e847890

Browse files
author
Henry Linjamäki
committed
OpenCL: Tiny runtime optimizations
Plus remove an unused member variable.
1 parent 02c8dd6 commit e847890

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

src/backend/OpenCL/CHIPBackendOpenCL.cc

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,15 +1059,18 @@ void CL_CALLBACK pfn_notify(cl_event Event, cl_int CommandExecStatus,
10591059

10601060
std::pair<std::vector<cl_event>, chipstar::LockGuardVector>
10611061
CHIPQueueOpenCL::addDependenciesQueueSync(
1062-
std::shared_ptr<chipstar::Event> TargetEvent) {
1062+
std::shared_ptr<chipstar::Event> &TargetEvent) {
10631063
auto [EventsToWaitOn, EventLocks] =
10641064
getSyncQueuesLastEvents(TargetEvent, false);
10651065
std::vector<cl_event> EventHandles;
1066-
EventHandles.reserve(EventsToWaitOn.size());
1067-
for (auto &Event : EventsToWaitOn) {
1068-
TargetEvent->addDependency(Event);
1069-
EventHandles.push_back(
1070-
std::static_pointer_cast<CHIPEventOpenCL>(Event)->ClEvent);
1066+
1067+
if (EventsToWaitOn.size()) {
1068+
EventHandles.reserve(EventsToWaitOn.size());
1069+
for (auto &Event : EventsToWaitOn) {
1070+
TargetEvent->addDependency(Event);
1071+
EventHandles.push_back(
1072+
std::static_pointer_cast<CHIPEventOpenCL>(Event)->ClEvent);
1073+
}
10711074
}
10721075
return {EventHandles, std::move(EventLocks)};
10731076
}

src/backend/OpenCL/CHIPBackendOpenCL.hh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ public:
340340
virtual std::shared_ptr<chipstar::Event>
341341
memPrefetchImpl(const void *Ptr, size_t Count) override;
342342
std::pair<std::vector<cl_event>, chipstar::LockGuardVector>
343-
addDependenciesQueueSync(std::shared_ptr<chipstar::Event> TargetEvent);
343+
addDependenciesQueueSync(std::shared_ptr<chipstar::Event> &TargetEvent);
344344

345345
private:
346346
void switchModeTo(QueueMode Mode);
@@ -411,7 +411,6 @@ public:
411411
: ExecItem(GirdDim, BlockDim, SharedMem, ChipQueue) {}
412412

413413
virtual ~CHIPExecItemOpenCL() override {}
414-
SPVFuncInfo FuncInfo;
415414
virtual void setupAllArgs() override;
416415
cl_kernel getKernelHandle();
417416

0 commit comments

Comments
 (0)