Skip to content

Conversation

@cval26
Copy link
Collaborator

@cval26 cval26 commented Jun 28, 2023

I'm opening this draft PR so that you can stay up to date with my changes in the code, and so that I can ask you questions about specific parts of the code that I'm unsure of. I'll add comments to the parts of the code I have questions on.

I'll push new changes as I implement them so that we can discuss them. Once we have a correct implementation I can go back and edit the commit history so that it's easier to review.

The indentation in some parts of the code seems to be off in the diff files. I'm not sure why; it doesn't look like that in my editor.

Changes made so far:

  • formed a new, combined NNLS problem for both velocity and energy;
  • formed the new RHS force vectors used in the online timestepping phase;
  • added the energy identity vector to each time window's reduced energy basis;

@cval26 cval26 changed the title Implementation of energy-conserving EQP Energy-conserving EQP Jun 28, 2023
Base automatically changed from rom-eqp to rom November 12, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants