Merge branch 'ENG-10907-smartling-fixes' of github.com:anaghav2023/builder into ENG-10907-smartling-fixes

Author: anaghav2023

packages/utils/src/translation-helpers.test.ts

@@ -54,6 +54,38 @@ test('getTranslateableFields from content to match snapshot', async () => {
             },
           },
         },
+        {
+          meta: {
+            instructions: 'Button with plain text',
+          },
+          id: 'button-plain-text-id',
+          '@type': '@builder.io/sdk:Element',
+          component: {
+            name: 'Core:Button',
+            options: {
+              text: 'Cute Baby',
+              openLinkInNewTab: false,
+            },
+          },
+        },
+        {
+          meta: {
+            instructions: 'Button with pre-localized text',
+          },
+          id: 'button-localized-text-id',
+          '@type': '@builder.io/sdk:Element',
+          component: {
+            name: 'Core:Button',
+            options: {
+              text: {
+                '@type': localizedType,
+                'en-US': 'Click Me!',
+                Default: 'Click Here',
+              },
+              openLinkInNewTab: true,
+            },
+          },
+        },
         {
           '@type': '@builder.io/sdk:Element',
           id: 'builder-custom-component-id',

packages/utils/src/translation-helpers.ts

@@ -207,6 +207,21 @@ export function getTranslateableFields(
         };
       }
 
+      if (el && el.id && el.component?.name === 'Core:Button' && !el.meta?.excludeFromTranslation) {
+        const componentText = el.component.options?.text;
+        if (componentText) {
+          const textValue = typeof componentText === 'string'
+            ? componentText
+            : componentText?.[sourceLocaleId] || componentText?.Default;
+          if (textValue) {
+            results[`blocks.${el.id}#text`] = {
+              value: textValue,
+              instructions: el.meta?.instructions || defaultInstructions,
+            };
+          }
+        }
+      }
+
       if (el && el.id && el.component?.name === 'Symbol') {
         const symbolInputs = Object.entries(el.component?.options?.symbol?.data) || [];
         if (symbolInputs.length) {
@@ -342,6 +357,45 @@ export function applyTranslation(
         });
       }
 
+      // Core:Button special handling - similar to Text component
+      if (
+        el &&
+        el.id &&
+        el.component?.name === 'Core:Button' &&
+        !el.meta?.excludeFromTranslation &&
+        translation[`blocks.${el.id}#text`]
+      ) {
+        const localizedValues =
+          typeof el.component.options?.text === 'string'
+            ? {
+                Default: el.component.options.text,
+              }
+            : el.component.options.text;
+
+        const updatedElement = {
+          ...el,
+          meta: {
+            ...el.meta,
+            translated: true,
+            // this tells the editor that this is a forced localized input similar to clicking the globe icon
+            'transformed.text': 'localized',
+          },
+          component: {
+            ...el.component,
+            options: {
+              ...el.component.options,
+              text: {
+                '@type': localizedType,
+                ...localizedValues,
+                [locale]: unescapeStringOrObject(translation[`blocks.${el.id}#text`].value),
+              },
+            },
+          },
+        };
+        
+        this.update(updatedElement);
+      }
+
       // custom components
       if (el && el.id && el.meta?.localizedTextInputs) {
         // there's a localized input

packages/utils/tsconfig.json

@@ -7,7 +7,8 @@
     "esModuleInterop": true,
     "skipLibCheck": true,
     "strict": true,
-    "declaration": true
+    "declaration": true,
+    "types": []
   },
   "include": ["./src"],
   "exclude": ["node_modules", "**/*.test.ts"]

plugins/smartling/package-lock.json

@@ -125,7 +125,7 @@
     "typescript": "^3.0.3"
   },
   "dependencies": {
-    "@builder.io/utils": "1.1.25-2",
+    "@builder.io/utils": "1.1.26",
     "fast-json-stable-stringify": "^2.1.0",
     "lodash": "^4.17.21",
     "object-hash": "^3.0.0",

plugins/smartling/package.json

@@ -747,8 +747,8 @@ const initializeSmartlingPlugin = async () => {
       },
       async onClick(content) {
         const translationBatch = fastClone(content.meta).translationBatch;
-        // https://dashboard.smartling.com/app/projects/0e6193784/strings/jobs/schqxtpcnxix
-        const smartlingFile = `https://dashboard.smartling.com/app/projects/${translationBatch.projectId}/strings/jobs/${translationBatch.translationJobUid}`;
+        // Filter by file URI (content ID) to show all translations across all jobs
+        const smartlingFile = `https://dashboard.smartling.com/app/projects/${translationBatch.projectId}/strings/?urlsFilter.urls=${content.id}&limit=200&offset=0`;
         window.open(smartlingFile, '_blank', 'noreferrer,noopener');
       },
     });