Skip to content

Using yarn #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kohei-takata merged 2 commits into from
Apr 8, 2017
Merged

Using yarn #393

kohei-takata merged 2 commits into from
Apr 8, 2017

Conversation

@sota1235
Copy link
Contributor

@sota1235 sota1235 commented Apr 7, 2017

Fixing version of dependencies by using yarn.lock.

@sota1235 sota1235 self-assigned this Apr 7, 2017
asmsuechan
asmsuechan approved these changes Apr 7, 2017
View reviewed changes
Copy link
Contributor

@asmsuechan asmsuechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kohei-takata
kohei-takata reviewed Apr 8, 2017
View reviewed changes
Copy link
Contributor

@kohei-takata kohei-takata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kohei-takata kohei-takata merged commit fe7c05a into master Apr 8, 2017
@kohei-takata kohei-takata deleted the feature-use-yarn branch April 8, 2017 03:51
@sota1235 sota1235 mentioned this pull request Apr 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kohei-takata kohei-takata kohei-takata left review comments

@asmsuechan asmsuechan asmsuechan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sota1235 sota1235

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sota1235 @kohei-takata @asmsuechan