Skip to content

Added sorting direction buttons #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 2 commits into from
Feb 24, 2020
Merged

Added sorting direction buttons #3474

Rokt33r merged 2 commits into from
Feb 24, 2020

Conversation

@AlexGarrity
Copy link
Contributor

@AlexGarrity AlexGarrity commented Feb 17, 2020 •
edited
Loading

Description

This PR adds two buttons next to the existing "list style" buttons which allow the user to specify whether the note list should be sorted in ascending or descending order.

test

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 17, 2020
ZeroX-DG
ZeroX-DG approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Feb 18, 2020
@Rokt33r Rokt33r added this to the v0.15.0 milestone Feb 24, 2020
@Rokt33r Rokt33r merged commit afbe439 into BoostIO:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees

No one assigned

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Milestone

v0.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexGarrity @ZeroX-DG @Rokt33r