Issue 1706 tag rename - finishing #2989

[AWolf81]

Description

@khaliqgant I hope it's OK that I'm adding the requested changes from your PR #2989.
My PR adds a dialog if the new tag is matching an existing tag and shows a warning dialog.

@ZeroX-DG can you please check if the feature is now like you expect it? Please also check if the copy of the dialog is OK.

Linting issue is present here too. I've commited with --no-verify option. Linting will be fixed in my other open PR.

Issue fixed

#1706

Type of changes

• ⚪ Bug fix (Change that fixed an issue)
• ⚪ Breaking change (Change that can cause existing functionality to change)
• 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
• ⚪ Feature (Change that adds new functionality)
• ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

• 🔘 My code follows the project code style
• ⚪ I have written test for my code and it has been tested
• ⚪ All existing tests have been passed
• 🔘 I have attached a screenshot/video to visualize my change if possible

Example merge warning (tag was 2nd and renamed to react - react tag already exists)

[Flexo013]

@AWolf81 Could you investigate the failing check of the CI?

[AWolf81]

@Flexo013 sure, I've checked it and fixed the build.

Update
Sorry, for the confusion. Seem like we're not using space-before-parens rule - so no space before the function parens is used here. Not sure why it was added. I need to check why format on save is not working for me at the moment.

[ZeroX-DG]

@AWolf81 can you change the style to of the way we currently styling right now? Also the rename modal background doesn't match with some of the theme

[AWolf81]

@ZeroX-DG Theme should be OK now. Please have a look.
I've noticed that it's not looking like the create new folder modal but I think the look is better with just the border below the input instead of the complete white border. But let me know how this should look or if that's OK.

I've noticed one point that could be improved. If you clicked on a tag to rename and click confirm with-out any changes there was also the merge dialog. I've added a check so it will just close the modal with-out the merge dialog if tag is not changed.

Update 02.04.2020
@ZeroX-DG Travis is running on my instance. Not sure why it is not running here. Maybe it needs to be re-run manually.

[ZeroX-DG]

Sorry for the wait @AWolf81 LGTM 🎉 I think Travis got some error with it, not just you, Travis not running on many PR. I think we can try switching to something like Github Action 😄

[khaliqgant]

Totally missed the pings, thanks for wrapping this up @AWolf81!