Update zh_TW translation of build.md #3414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete translation. Sync with English version. [1] https://github.com/BoostIO/Boostnote/blob/master/docs/build.md.
ZeroX-DG
added
the
help wanted 🆘
Member
|
@xatier can you introduce someone to review this PR? |
Contributor
Author
|
Maybe @rayou? The one who contributed to this doc in the past. |
rayou
approved these changes
Jan 6, 2020
Contributor
rayou
left a comment
rayou
left a comment
There was a problem hiding this comment.
One suggestion added, the rest LGTM. 👍
docs/zh_TW/build.md
Outdated
| https://github.com/BoostIO/Boostnote/pull/2794 | ||
| </pre> | ||
| 接著，於底下步驟中把 \<PR> 換成這個號碼 (沒有括號)。 | ||
| 請將上面的 URL 中的 \<PR> 換置成 2794。 |
Contributor
There was a problem hiding this comment.
Change 請將上面的 to 請將下方 since the URLs are down below. I've updated build.md accordingly.
text change per @rayou's suggestion.
ZeroX-DG
approved these changes
Jan 9, 2020
Member
ZeroX-DG
left a comment
ZeroX-DG
left a comment
There was a problem hiding this comment.
probably will merge this next week if everyone agree with this translation
ZeroX-DG
added
approved 👍
Contributor
Author
|
@ZeroX-DG any reason this is not merged yet? |
Member
Rokt33r
removed
the
approved 👍
Member
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete translation.
Sync with English version.
[1] https://github.com/BoostIO/Boostnote/blob/master/docs/build.md.
Description
Update zh_TW translation of build.md.
Issue fixed
Type of changes
Checklist: