Skip to content

Fix prettier configuration #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 1 commit into from
Jan 29, 2020
Merged

Fix prettier configuration #3413

Rokt33r merged 1 commit into from
Jan 29, 2020

Conversation

@JenyMzo
Copy link

@JenyMzo JenyMzo commented Jan 4, 2020 •
edited by issuehunt-oss bot
Loading

Description

Bug fix (sets tabWidth to 2 on prettier configuration and ConfigManager so checkboxes can be clikable).

Issue fixed

#3361

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible
IssueHunt Summary

Referenced issues

This pull request has been submitted to:

IssueHunt has been backed by the following sponsors. Become a sponsor

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Jan 6, 2020
ZeroX-DG
ZeroX-DG approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 6, 2020
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Jan 29, 2020
@Rokt33r Rokt33r added this to the v0.15.0 milestone Jan 29, 2020
@Rokt33r Rokt33r merged commit 31ffbd9 into BoostIO:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JenyMzo @ZeroX-DG @Flexo013 @Rokt33r