Include build dependency packages cmds on build docs #3304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbawebba
suggested changes
Oct 23, 2019
Contributor
robbawebba
left a comment
robbawebba
left a comment
There was a problem hiding this comment.
Thanks for adding these details! I just have a couple suggestions for improvement. Please take a look and let me know what you think.
robbawebba
approved these changes
Oct 25, 2019
cyrus303
approved these changes
Dec 14, 2019
cyrus303
approved these changes
Dec 14, 2019
Member
|
LGTM! |
Rokt33r
added
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes the required build dependency packages to build the app
Most people tend to overlook:
Including it gives them a heads up.
Issue fixed
#3278
#3278 (comment)
Type of changes