Skip to content

Admonition #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 2 commits into from
Nov 21, 2019
Merged

Admonition #3297

Rokt33r merged 2 commits into from
Nov 21, 2019

Conversation

@ibraude
Copy link
Contributor

@ibraude ibraude commented Oct 21, 2019 •
edited
Loading

Description

Added Question, Quote, and Abstract Markdown-Admonition types

image

Issue fixed

#3295

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ibraude ibraude mentioned this pull request Oct 21, 2019
Closed
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Oct 21, 2019
arcturus140
arcturus140 approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@arcturus140 arcturus140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

ZeroX-DG
ZeroX-DG approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 2, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Nov 21, 2019
@Rokt33r Rokt33r added this to the v0.14.0 milestone Nov 21, 2019
@Rokt33r Rokt33r merged commit 489fc65 into BoostIO:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

+1 more reviewer

@arcturus140 arcturus140 arcturus140 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.14.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ibraude @ZeroX-DG @arcturus140 @Rokt33r