-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Feature] Add support for plantUML mindmap, wbs, gantt #3249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
browser/lib/markdown.js
Outdated
| }) | ||
|
|
||
| // Mindmap support | ||
| this.md.use(require('markdown-it-plantuml'), { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using require for every type of map, can we just require once and use it here?
const plantuml = require('markdown-it-plantuml');
this.md.use(plantuml, {...})
this.md.use(plantuml, {...})
this.md.use(plantuml, {...})There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please edit your code and I'll approve right after this 😃
browser/lib/markdown.js
Outdated
| openMarker: '@startgantt', | ||
| closeMarker: '@endgantt', | ||
| generateSource: function (umlCode) { | ||
| const stripTrailingSlash = (url) => url.endsWith('/') ? url.slice(0, -1) : url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please share this stripTrailingSlash function instead of recreating it every time.
ZeroX-DG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Copy of falsely closed pull request #3010
Description
I have added supprt for mindmap, wbs and gantt charts in plantuml. I just copied the part for the part for Ditaa chart and change the @ indicators and switched to svg output.
I havent added any tests, since I am not shure how. Test and lint have same output as current master
Issue fixed
Type of changes
Checklist: