Skip to content

Conversation

@MSSandroid
Copy link
Contributor

Copy of falsely closed pull request #3010

Description

I have added supprt for mindmap, wbs and gantt charts in plantuml. I just copied the part for the part for Ditaa chart and change the @ indicators and switched to svg output.
I havent added any tests, since I am not shure how. Test and lint have same output as current master

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ✅ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ✅ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ✅ All existing tests have been passed
  • ✅ I have attached a screenshot/video to visualize my change if possible

Screenshot_20190518_145129

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Sep 16, 2019
@Flexo013 Flexo013 requested a review from ZeroX-DG September 16, 2019 07:18
})

// Mindmap support
this.md.use(require('markdown-it-plantuml'), {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using require for every type of map, can we just require once and use it here?

const plantuml = require('markdown-it-plantuml');
this.md.use(plantuml, {...})
this.md.use(plantuml, {...})
this.md.use(plantuml, {...})

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit your code and I'll approve right after this 😃

openMarker: '@startgantt',
closeMarker: '@endgantt',
generateSource: function (umlCode) {
const stripTrailingSlash = (url) => url.endsWith('/') ? url.slice(0, -1) : url
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please share this stripTrailingSlash function instead of recreating it every time.

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 19, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Sep 19, 2019
@Rokt33r Rokt33r merged commit 6b1c595 into BoostIO:master Oct 10, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants