Skip to content

Stricter regex pattern in pathname matching, fix #3183 #3184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 1 commit into from
Oct 10, 2019
Merged

Stricter regex pattern in pathname matching, fix #3183 #3184

Rokt33r merged 1 commit into from
Oct 10, 2019

Conversation

@hikerpig
Copy link
Contributor

@hikerpig hikerpig commented Jul 30, 2019 •
edited
Loading

Description

location.pathname regex match should be Stricter

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)

@hikerpig hikerpig changed the title more strict regex pattern in pathname matching, fix #3183 Stricter regex pattern in pathname matching, fix #3183 Jul 30, 2019
@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Jul 30, 2019
ZeroX-DG
ZeroX-DG approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 21, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Oct 10, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Oct 10, 2019
@Rokt33r Rokt33r merged commit f181a7e into BoostIO:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.13.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hikerpig @ZeroX-DG @Flexo013 @Rokt33r